Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Add RowEncoder wrapper to RowEncodeTrait #1200

Merged
merged 2 commits into from
Dec 3, 2023
Merged

[C++] Add RowEncoder wrapper to RowEncodeTrait #1200

merged 2 commits into from
Dec 3, 2023

Conversation

PragmaTwice
Copy link
Member

@PragmaTwice PragmaTwice commented Dec 3, 2023 •
edited
Loading

What do these changes do?

Related issue number

We added a simpler interface to use RowEncodeTrait named RowEncoder, and renamed row_encoder.h to row_encode_trait.h.

Please review it commit by commit to avoid massive diff.

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

chaokunyang
chaokunyang approved these changes Dec 3, 2023
View reviewed changes
Copy link
Collaborator

@chaokunyang chaokunyang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this simplify the usage of encoder API, users doesn't have to pass visistor.

@chaokunyang
Copy link
Collaborator

Some minor issues, I see there some include starts with src such as src/fury/encoder/row_encoder.h. Can we remove src from include in another PR?

@chaokunyang chaokunyang merged commit 2480b8a into apache:main Dec 3, 2023
16 checks passed
@PragmaTwice
Copy link
Member Author

Some minor issues, I see there some include starts with src such as src/fury/encoder/row_encoder.h. Can we remove src from include in another PR?

Sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaokunyang chaokunyang chaokunyang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PragmaTwice @chaokunyang