Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Fix ownership problem for children writers by visitor #1193

Merged
merged 1 commit into from
Dec 1, 2023
Merged

[C++] Fix ownership problem for children writers by visitor #1193

merged 1 commit into from
Dec 1, 2023

Conversation

PragmaTwice
Copy link
Member

What do these changes do?

Here we use visitor pattern to solve the ownership issue for children of writers.

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@PragmaTwice PragmaTwice mentioned this pull request Dec 1, 2023
Open
12 tasks
chaokunyang
chaokunyang approved these changes Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@chaokunyang chaokunyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chaokunyang chaokunyang merged commit 3b0fea3 into apache:main Dec 1, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaokunyang chaokunyang chaokunyang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PragmaTwice @chaokunyang