Add GraalPy support #694

timfel · 2023-06-28T13:29:00Z

Description:
This adds support for graalpy as a Python to use when running setup-python

Related issue:
#693

Check list:

Mark if documentation changes are required.
Mark if tests were added or updated to cover the changes.

timfel · 2023-06-30T18:08:31Z

Locally npm test is passing and running the test-graalpy workflow I added with act also passes. Please let me know if this is going the right direction :)

timfel · 2023-07-03T18:09:44Z

Any thoughts?

dmitry-shibanov · 2023-07-12T17:53:14Z

Hello @timfel. Sorry for the late response. Could you please attach licenses information regarding to GraalPy ?

timfel · 2023-07-13T07:59:00Z

Hello @timfel. Sorry for the late response. Could you please attach licenses information regarding to GraalPy ?

Hi. My changes pull GraalPy from the open source Github repo, which is under UPL: https://github.com/oracle/graalpython/blob/master/LICENSE.txt#L5

timfel · 2023-07-25T15:09:51Z

Anything else I can help with?

timfel · 2023-08-07T11:14:52Z

Friendly ping :) Anything I can help with or clarify?

dmitry-shibanov · 2023-08-14T08:12:45Z

Hello @timfel. Sorry for the late response. For now we're investigating it. We'll ping you If we need any help. Thank you.

src/install-graalpy.ts

.github/workflows/test-graalpy.yml

src/install-graalpy.ts

dmitry-shibanov · 2023-08-23T16:59:48Z

src/install-graalpy.ts

+      ? 'aarch64'
+      : architecture;
+  const graalpyPlatform =
+    platform === 'win32'


Could you please change it to IS_WINDOWS from utils.ts

platform here is a parameter to the function. I think it would be weird if it overrode the passed parameter with the current platform.

src/install-graalpy.ts

dmitry-shibanov · 2023-08-23T17:02:32Z

Could you please run the npm ci && npm run format && npm run build command to resolve Basic Validation builds.

src/install-graalpy.ts

msimacek · 2023-08-29T11:51:54Z

Hi @dmitry-shibanov, I believe I addressed all your comments (except one where I commented). Could you please check again?

src/install-graalpy.ts

+    "Installing pip (GraalPy doesn't update pip because it uses a patched version of pip)"
+  );
+  const pythonBinary = path.join(pythonLocation, 'python');
+  await exec.exec(`${pythonBinary} -m ensurepip --default-pip`);


kurtmckee · 2023-09-11T12:25:00Z

.github/workflows/test-graalpy.yml

+    strategy:
+      fail-fast: false
+      matrix:
+        os: [macos-latest, ubuntu-20.04, ubuntu-latest]


GraalPy is available for Windows, too. Would it be an option to test against Windows?

For 23.0 there were no Windows binary releases. The upcoming 23.1 will have Windows releases, but they are very limited, things like native extensions do not work, yet. Tests for Windows will likely just not pass.

Our plan is to have more complete Windows support for our 2024 release, so we'll have to do a follow up PR next year.

kurtmckee · 2023-09-11T12:26:51Z

__tests__/find-graalpy.test.ts

+const toolDir = path.join(__dirname, 'runner', 'tools');
+const tempDir = path.join(__dirname, 'runner', 'temp');
+
+/* GraalPy doesn't have a windows release yet */


GraalPy is downloadable for Windows; is this comment still correct?

It is correct, the last release for GraalPy is 23.0.1 and doesn't have Windows binaries. The upcoming 23.1 will have binaries, but they are very limited.

timfel · 2023-09-16T04:20:29Z

Anything else to do here? We would really like this to go in so that Python projects that already use setup-python can easily start testing against GraalPy :)

timfel · 2023-10-05T18:32:59Z

Friendly ping :)

kurtmckee · 2023-10-06T13:51:44Z

When this merges, I'll work to update #611 so that GraalPy is supported for robust cache-busting as well.

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/setup-python](https://togithub.com/actions/setup-python) | action | minor | `v4.7.1` -> `v4.8.0` | --- ### Release Notes <details> <summary>actions/setup-python (actions/setup-python)</summary> ### [`v4.8.0`](https://togithub.com/actions/setup-python/releases/tag/v4.8.0) [Compare Source](https://togithub.com/actions/setup-python/compare/v4.7.1...v4.8.0) #### What's Changed In scope of this release we added support for GraalPy ([https://github.com/actions/setup-python/pull/694](https://togithub.com/actions/setup-python/pull/694)). You can use this snippet to set up GraalPy: ```yaml steps: - uses: actions/checkout@v4 - uses: actions/setup-python@v4 with: python-version: 'graalpy-22.3' - run: python my_script.py ``` Besides, the release contains such changes as: - Trim python version when reading from file by [@FerranPares](https://togithub.com/FerranPares) in [https://github.com/actions/setup-python/pull/628](https://togithub.com/actions/setup-python/pull/628) - Use non-deprecated versions in examples by [@jeffwidman](https://togithub.com/jeffwidman) in [https://github.com/actions/setup-python/pull/724](https://togithub.com/actions/setup-python/pull/724) - Change deprecation comment to past tense by [@jeffwidman](https://togithub.com/jeffwidman) in [https://github.com/actions/setup-python/pull/723](https://togithub.com/actions/setup-python/pull/723) - Bump [@babel/traverse](https://togithub.com/babel/traverse) from 7.9.0 to 7.23.2 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/actions/setup-python/pull/743](https://togithub.com/actions/setup-python/pull/743) - advanced-usage.md: Encourage the use actions/checkout@v4 by [@cclauss](https://togithub.com/cclauss) in [https://github.com/actions/setup-python/pull/729](https://togithub.com/actions/setup-python/pull/729) - Examples now use checkout@v4 by [@simonw](https://togithub.com/simonw) in [https://github.com/actions/setup-python/pull/738](https://togithub.com/actions/setup-python/pull/738) - Update actions/checkout to v4 by [@dmitry-shibanov](https://togithub.com/dmitry-shibanov) in [https://github.com/actions/setup-python/pull/761](https://togithub.com/actions/setup-python/pull/761) #### New Contributors - [@FerranPares](https://togithub.com/FerranPares) made their first contribution in [https://github.com/actions/setup-python/pull/628](https://togithub.com/actions/setup-python/pull/628) - [@timfel](https://togithub.com/timfel) made their first contribution in [https://github.com/actions/setup-python/pull/694](https://togithub.com/actions/setup-python/pull/694) - [@jeffwidman](https://togithub.com/jeffwidman) made their first contribution in [https://github.com/actions/setup-python/pull/724](https://togithub.com/actions/setup-python/pull/724) **Full Changelog**: actions/setup-python@v4...v4.8.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/rpdelaney/downforeveryone).

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/setup-python](https://togithub.com/actions/setup-python) | action | minor | `v4.7.1` -> `v4.8.0` | --- ### Release Notes <details> <summary>actions/setup-python (actions/setup-python)</summary> ### [`v4.8.0`](https://togithub.com/actions/setup-python/releases/tag/v4.8.0) [Compare Source](https://togithub.com/actions/setup-python/compare/v4.7.1...v4.8.0) #### What's Changed In scope of this release we added support for GraalPy ([https://github.com/actions/setup-python/pull/694](https://togithub.com/actions/setup-python/pull/694)). You can use this snippet to set up GraalPy: ```yaml steps: - uses: actions/checkout@v4 - uses: actions/setup-python@v4 with: python-version: 'graalpy-22.3' - run: python my_script.py ``` Besides, the release contains such changes as: - Trim python version when reading from file by [@FerranPares](https://togithub.com/FerranPares) in [https://github.com/actions/setup-python/pull/628](https://togithub.com/actions/setup-python/pull/628) - Use non-deprecated versions in examples by [@jeffwidman](https://togithub.com/jeffwidman) in [https://github.com/actions/setup-python/pull/724](https://togithub.com/actions/setup-python/pull/724) - Change deprecation comment to past tense by [@jeffwidman](https://togithub.com/jeffwidman) in [https://github.com/actions/setup-python/pull/723](https://togithub.com/actions/setup-python/pull/723) - Bump [@babel/traverse](https://togithub.com/babel/traverse) from 7.9.0 to 7.23.2 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/actions/setup-python/pull/743](https://togithub.com/actions/setup-python/pull/743) - advanced-usage.md: Encourage the use actions/checkout@v4 by [@cclauss](https://togithub.com/cclauss) in [https://github.com/actions/setup-python/pull/729](https://togithub.com/actions/setup-python/pull/729) - Examples now use checkout@v4 by [@simonw](https://togithub.com/simonw) in [https://github.com/actions/setup-python/pull/738](https://togithub.com/actions/setup-python/pull/738) - Update actions/checkout to v4 by [@dmitry-shibanov](https://togithub.com/dmitry-shibanov) in [https://github.com/actions/setup-python/pull/761](https://togithub.com/actions/setup-python/pull/761) #### New Contributors - [@FerranPares](https://togithub.com/FerranPares) made their first contribution in [https://github.com/actions/setup-python/pull/628](https://togithub.com/actions/setup-python/pull/628) - [@timfel](https://togithub.com/timfel) made their first contribution in [https://github.com/actions/setup-python/pull/694](https://togithub.com/actions/setup-python/pull/694) - [@jeffwidman](https://togithub.com/jeffwidman) made their first contribution in [https://github.com/actions/setup-python/pull/724](https://togithub.com/actions/setup-python/pull/724) **Full Changelog**: actions/setup-python@v4...v4.8.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/GoogleCloudPlatform/genai-databases-retrieval-app).

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/setup-python](https://togithub.com/actions/setup-python) | action | major | `v4.7.1` -> `v5.0.0` | --- ### Release Notes <details> <summary>actions/setup-python (actions/setup-python)</summary> ### [`v5.0.0`](https://togithub.com/actions/setup-python/releases/tag/v5.0.0) [Compare Source](https://togithub.com/actions/setup-python/compare/v4.8.0...v5.0.0) #### What's Changed In scope of this release, we update node version runtime from node16 to node20 ([https://github.com/actions/setup-python/pull/772](https://togithub.com/actions/setup-python/pull/772)). Besides, we update dependencies to the latest versions. **Full Changelog**: actions/setup-python@v4.8.0...v5.0.0 ### [`v4.8.0`](https://togithub.com/actions/setup-python/releases/tag/v4.8.0) [Compare Source](https://togithub.com/actions/setup-python/compare/v4.7.1...v4.8.0) #### What's Changed In scope of this release we added support for GraalPy ([https://github.com/actions/setup-python/pull/694](https://togithub.com/actions/setup-python/pull/694)). You can use this snippet to set up GraalPy: ```yaml steps: - uses: actions/checkout@v4 - uses: actions/setup-python@v4 with: python-version: 'graalpy-22.3' - run: python my_script.py ``` Besides, the release contains such changes as: - Trim python version when reading from file by [@FerranPares](https://togithub.com/FerranPares) in [https://github.com/actions/setup-python/pull/628](https://togithub.com/actions/setup-python/pull/628) - Use non-deprecated versions in examples by [@jeffwidman](https://togithub.com/jeffwidman) in [https://github.com/actions/setup-python/pull/724](https://togithub.com/actions/setup-python/pull/724) - Change deprecation comment to past tense by [@jeffwidman](https://togithub.com/jeffwidman) in [https://github.com/actions/setup-python/pull/723](https://togithub.com/actions/setup-python/pull/723) - Bump [@babel/traverse](https://togithub.com/babel/traverse) from 7.9.0 to 7.23.2 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/actions/setup-python/pull/743](https://togithub.com/actions/setup-python/pull/743) - advanced-usage.md: Encourage the use actions/checkout@v4 by [@cclauss](https://togithub.com/cclauss) in [https://github.com/actions/setup-python/pull/729](https://togithub.com/actions/setup-python/pull/729) - Examples now use checkout@v4 by [@simonw](https://togithub.com/simonw) in [https://github.com/actions/setup-python/pull/738](https://togithub.com/actions/setup-python/pull/738) - Update actions/checkout to v4 by [@dmitry-shibanov](https://togithub.com/dmitry-shibanov) in [https://github.com/actions/setup-python/pull/761](https://togithub.com/actions/setup-python/pull/761) #### New Contributors - [@FerranPares](https://togithub.com/FerranPares) made their first contribution in [https://github.com/actions/setup-python/pull/628](https://togithub.com/actions/setup-python/pull/628) - [@timfel](https://togithub.com/timfel) made their first contribution in [https://github.com/actions/setup-python/pull/694](https://togithub.com/actions/setup-python/pull/694) - [@jeffwidman](https://togithub.com/jeffwidman) made their first contribution in [https://github.com/actions/setup-python/pull/724](https://togithub.com/actions/setup-python/pull/724) **Full Changelog**: actions/setup-python@v4...v4.8.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/petretiandrea/home-assistant-tapo-p100).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

kurtmckee · 2024-05-07T02:28:04Z

@timfel It looks like the 24.x release series is out. Does this include Windows support that could integrate with setup-python? 🤞

timfel · 2024-05-07T17:52:47Z

@timfel It looks like the 24.x release series is out. Does this include Windows support that could integrate with setup-python? 🤞

It does indeed. We also finally managed to get nightly builds out with some json metadata (https://github.com/graalvm/graal-languages-ea-builds/blob/main/graalpy/versions/latest-ea.json), so we'll integrate that, too, so people can test on upcoming versions as well.

timfel requested a review from a team as a code owner June 28, 2023 13:29

timfel force-pushed the tim/graalpy-support branch from 41efa4a to 1cbe27a Compare June 28, 2023 13:32

timfel mentioned this pull request Jun 28, 2023

Add GraalPy support #693

Closed

timfel force-pushed the tim/graalpy-support branch from af8b00e to 2c87a2d Compare July 1, 2023 07:57

dusan-trickovic linked an issue Jul 13, 2023 that may be closed by this pull request

Add GraalPy support #693

Closed

dusan-trickovic removed a link to an issue Jul 13, 2023

Add GraalPy support #693

Closed

dusan-trickovic linked an issue Jul 13, 2023 that may be closed by this pull request

Add GraalPy support #693

Closed

timfel mentioned this pull request Jul 18, 2023

Basic GraalPy Support PyO3/pyo3#3247

Merged

agronholm mentioned this pull request Aug 20, 2023

Produce correct ABI tags for GraalPy pypa/wheel#557

Merged

timfel added 5 commits August 21, 2023 10:49

Add support for graalpy

ad7b7ba

add graalpy test workflow

f40a022

format, lint and build

6db14b2

symlink graalpy binaries names

928058c

fix macos names for graalpy

b695933

timfel force-pushed the tim/graalpy-support branch from 2c87a2d to b695933 Compare August 21, 2023 08:59

github-advanced-security bot found potential problems Aug 23, 2023

View reviewed changes

src/install-graalpy.ts Fixed Show fixed Hide fixed

src/install-graalpy.ts Fixed Show fixed Hide fixed

dmitry-shibanov reviewed Aug 23, 2023

View reviewed changes

src/install-graalpy.ts Show resolved Hide resolved

msimacek added 4 commits August 25, 2023 17:44

Don't attempt to update pip for graalpy

b271e81

Remove test schedule

fb29473

Extract common getBinaryDirectory function for PyPy and GraalPy

08f6b91

Clean up and format

3d8a1eb

msimacek added 3 commits August 29, 2023 13:36

Pass GitHub token to GraalPy queries

62fe528

Utilize pagination when querying GraalPy GitHub releases

feb1894

Build

7673153

github-advanced-security bot found potential problems Aug 30, 2023

View reviewed changes

msimacek added 6 commits August 30, 2023 10:01

Fix lint errors

546edbc

Deal with possible multiple artifacts for a single releases

8c79e75

Skip few GraalPy tests on windows - we don't have a windows release yet

cc7e956

Fix GraalPy test on Mac OS

7f48d18

Build

5b60f8c

Skip one more GraalPy test on windows

6713183

kurtmckee reviewed Sep 11, 2023

View reviewed changes

dmitry-shibanov approved these changes Oct 6, 2023

View reviewed changes

dmitry-shibanov merged commit 5f2af21 into actions:main Oct 10, 2023

timfel deleted the tim/graalpy-support branch October 25, 2023 14:49

kurtmckee mentioned this pull request Nov 1, 2023

GraalPy support tox-dev/tox#3148

Closed

LoicGrobol mentioned this pull request Dec 6, 2023

build(deps): bump actions/setup-python from 4 to 5 hopsparser/hopsparser#99

Closed

fniephaus mentioned this pull request Dec 11, 2023

Upgrade Java and Python Integration Example graalvm/graalvm-demos#225

Closed

jasonjoh mentioned this pull request Dec 11, 2023

Bump actions/setup-python from 4 to 5 microsoftgraph/msgraph-sample-pythondjangoapp#126

Merged

timfel mentioned this pull request May 28, 2024

Add graalpy early-access and windows builds #880

Open

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add GraalPy support #694

Add GraalPy support #694

timfel commented Jun 28, 2023

timfel commented Jun 30, 2023 •

edited

Loading

timfel commented Jul 3, 2023

dmitry-shibanov commented Jul 12, 2023

timfel commented Jul 13, 2023

timfel commented Jul 25, 2023

timfel commented Aug 7, 2023

dmitry-shibanov commented Aug 14, 2023

dmitry-shibanov Aug 23, 2023

msimacek Aug 29, 2023

dmitry-shibanov commented Aug 23, 2023

msimacek commented Aug 29, 2023

kurtmckee Sep 11, 2023

timfel Sep 11, 2023

timfel Sep 11, 2023

kurtmckee Sep 11, 2023

timfel Sep 11, 2023

timfel commented Sep 16, 2023

timfel commented Oct 5, 2023

kurtmckee commented Oct 6, 2023

kurtmckee commented May 7, 2024

timfel commented May 7, 2024

Add GraalPy support #694

Add GraalPy support #694

Conversation

timfel commented Jun 28, 2023

timfel commented Jun 30, 2023 • edited Loading

timfel commented Jul 3, 2023

dmitry-shibanov commented Jul 12, 2023

timfel commented Jul 13, 2023

timfel commented Jul 25, 2023

timfel commented Aug 7, 2023

dmitry-shibanov commented Aug 14, 2023

dmitry-shibanov Aug 23, 2023

Choose a reason for hiding this comment

msimacek Aug 29, 2023

Choose a reason for hiding this comment

dmitry-shibanov commented Aug 23, 2023

msimacek commented Aug 29, 2023

kurtmckee Sep 11, 2023

Choose a reason for hiding this comment

timfel Sep 11, 2023

Choose a reason for hiding this comment

timfel Sep 11, 2023

Choose a reason for hiding this comment

kurtmckee Sep 11, 2023

Choose a reason for hiding this comment

timfel Sep 11, 2023

Choose a reason for hiding this comment

timfel commented Sep 16, 2023

timfel commented Oct 5, 2023

kurtmckee commented Oct 6, 2023

kurtmckee commented May 7, 2024

timfel commented May 7, 2024

timfel commented Jun 30, 2023 •

edited

Loading