Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to latest actions/artifact NPM package #195

Merged
merged 5 commits into from
Jan 4, 2023
Merged

Update to latest actions/artifact NPM package #195

merged 5 commits into from
Jan 4, 2023

Conversation

konradpabjan
Copy link
Collaborator

@konradpabjan konradpabjan commented Jan 4, 2023 •
edited
Loading

This PR contains 4 sets of changes

  • Updates @actions/artifact to version 1.1.1 which was released yesterday with a few bug fixes specifically for download-artifact. See https://github.com/actions/toolkit/blob/main/packages/artifact/RELEASES.md
  • Bump actions/checkout@v2 to v3 in various CI workflows
  • Bump actions/setup-node@v1 to v3 and add caching + use 16 which is what the runner now will use for all actions executions. The runner ships with it's own binary of node 12 + 16. Node 12 is going away
  • Create a devcontainer so that it is easier to use codespaces off the bat. Right now if you create a codespace than it defaults to node 14 and an old NPM version which causes the lock-file version to go back down to 1 where we want to stay and the newer 2nd version

@konradpabjan konradpabjan requested a review from a team as a code owner January 4, 2023 19:57
@konradpabjan konradpabjan marked this pull request as draft January 4, 2023 20:26
@konradpabjan konradpabjan marked this pull request as ready for review January 4, 2023 20:26
@konradpabjan konradpabjan deleted the konradpabjan/package-updates branch January 4, 2023 20:34
@konradpabjan konradpabjan restored the konradpabjan/package-updates branch January 4, 2023 20:34
@konradpabjan konradpabjan reopened this Jan 4, 2023
@konradpabjan konradpabjan merged commit 9bc31d5 into main Jan 4, 2023
@jbarlow83 jbarlow83 mentioned this pull request Dec 18, 2023
Closed
@Teddy-van-Jerry Teddy-van-Jerry mentioned this pull request Dec 19, 2023
Merged
@ansh21 ansh21 mentioned this pull request Jun 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eggyhead eggyhead eggyhead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@konradpabjan @eggyhead