-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reading package version from metadata #20
Comments
You probably have moved on by now, but I'm still going to comment on your request. In order to override Can you think of a better solution?
|
@abichinger as for now you are not checking if pyproject.project.version exists
So dynamic version set is not possible for now Maybe it's better to add option, which disables version change in local files, only build and upload package |
@v1ack I think skipping the version update defeats the purpose of this package. I imagine we could add an option called Example: // .releaserc.json
{
"branches": ["main"],
"plugins": [
"@semantic-release/commit-analyzer",
"@semantic-release/release-notes-generator",
[
"semantic-release-pypi",
{
"versionCmd": "hatch version {version}"
}
],
]
} |
@abichinger yes, sounds good |
@v1ack That's right, the difference will be that normalizeVersion is called before running the command set by semantic-release-pypi/lib/util.ts Lines 8 to 21 in 3210d50
Sources: |
versionCmd can be used to dynamically set the version
# [4.1.0](v4.0.3...v4.1.0) (2024-12-10) ### Features * add option versionCmd [#20](#20) ([c0d4031](c0d4031))
|
When making a release, the version number is hard coded. However,
setup.cfg
allows reading the package version from configuration files for example (if the pckg name ismy_package
):setup.cfg
Problem: current implementation will override the version in
setup.cfg
when it should override inVERSION
.The text was updated successfully, but these errors were encountered: