Allow psr/http-message v2 #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
force-pushed
the
psr7v2
branch
11 times, most recently
from
e707b2b to
5a5a72b
Compare
|
PR is ready, tests will still pass after php-http/psr7-integration-tests#68 is merged. |
Nyholm
approved these changes
Apr 17, 2023
There was a problem hiding this comment.
Im happy with this.
Just waiting on php-http/psr7-integration-tests#68
nicolas-grekas
force-pushed
the
psr7v2
branch
2 times, most recently
from
2b30957 to
6ef3a4a
Compare
|
PR updated and rebased. |
nicolas-grekas
force-pushed
the
psr7v2
branch
2 times, most recently
from
e087722 to
634154b
Compare
nicolas-grekas
commented
Apr 20, 2023
| "php-http/message-factory": "^1.0", | ||
| "psr/http-factory": "^1.0" | ||
| }, | ||
| "require-dev": { | ||
| "phpunit/phpunit": "^7.5 || 8.5 || 9.4", | ||
| "php-http/psr7-integration-tests": "^1.0", | ||
| "php-http/psr7-integration-tests": "^1.0@dev", |
There was a problem hiding this comment.
This line looks desirable to me: testing with @dev for the test suite means anticipating any unreleased issue with them.
|
I reran the CI, it is all green. Let's merge |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of #223 to not bump to PHP 7.2 when not needed.
Requires php-http/psr7-integration-tests#68