Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for null and undefined attributes when building xml (#585) #598

Merged
merged 2 commits into from
Jul 30, 2023
Merged

Fix for null and undefined attributes when building xml (#585) #598

merged 2 commits into from
Jul 30, 2023

Conversation

cecia234
Copy link
Contributor

@cecia234 cecia234 commented Jul 22, 2023 •
edited
Loading

Purpose / Goal

After the fix null and undefined attributes in the starting object do not cause odd whitespaces and newlines in the built xml, regardless of whether format is true or false. Issue #585

Perf test on XMLBuilder:

Running Suite: XML Builder benchmark
fxp : 76193.36948123561 requests/second
fxp - preserve order : 238552830.29948822 requests/second
xml2js  : 21083.181183955512 requests/second

Type

Please mention the type of PR

  • [x]Bug Fix
  • [ ]Refactoring / Technology upgrade
  • [ ]New Feature

cecia234 added 2 commits July 22, 2023 10:25
@cecia234
fix (xmlbuilder): null and undefined attributes are suppressed in the…
83c90cf 
… built xml (NaturalIntelligence#585)
@cecia234
test (xmlbuilder): add tests on null and undefined attributes building (
47b93d9 
NaturalIntelligence#585)

Null and Undefined attributes should be suppressed when ignoreAttributes is false
both when format is true and when it is false
@amitguptagwl
Copy link
Member

Thanks for your PR. Let me review it.

@coveralls
Copy link

Coverage Status

coverage: 98.221% (-0.02%) from 98.24% when pulling 47b93d9 on cecia234:fix#585 into a04cd1e on NaturalIntelligence:master.

@amitguptagwl amitguptagwl merged commit df7008f into NaturalIntelligence:master Jul 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cecia234 @amitguptagwl @coveralls