Set role=button on the Layer control
#7850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Falke-Design
approved these changes
Dec 9, 2021
Falke-Design
added
the
accessibility
mourner
approved these changes
Dec 10, 2021
|
Maybe using a |
|
@vanillajonathan see #7821. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6821 - This PR closes that issue because the WCAG error reported is only applicable to elements with
role=link(implicit from<a>in the case of the layer control) and not buttons (which this PR changes)!Closes #6869 - Unlike that PR, this doesn't set
aria-label(in addition to the existingtitle) as that's not only redundant but would also cause some screen readers to announce "Layers" twice - which is an obvious annoyance to screen reader users.Fix #7498.