Could you please double-check my understanding?

At first glance, the behavioural difference in this snippet

flowOf(1)
    .take(1)
    .onEach {  } // 1
    .onCompletion { println("??? $it") }
    .first()

with 1 being commented out or not just doesn't make any sense. I tried to figure it out by just looking at the commit message, and it was unclear, thus decided to understand the root cause before looking at the solution to avoid spoiling the fun review.

It seems to me that the root cause is the following:

1. take uses FlowCollector that it receives in an argument as an ownership token, and it checks the ownership in catch block
2. The problem is that FlowCollector is not unique to the take itself and, in fact, depends on the downstream operator. It might be a collector from onEach, or it might be an onCompletion collector.
3. onCompletion collector, which is collectWhile collector, throws an AbortFlowException and uses itself as an ownership token.
4. According to 2, ownership check in take might pass or might not pass, leading to the observed behaviour

So the root cause is straightforward -- we cannot use FlowCollector from an argument as an ownership token