Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unintuitive dispatching behavior in some rare cases with Android's Dispatchers.Main.immediate #3963

Closed
dkhalanskyjb opened this issue Dec 1, 2023 · 1 comment
Closed

Unintuitive dispatching behavior in some rare cases with Android's Dispatchers.Main.immediate #3963

dkhalanskyjb opened this issue Dec 1, 2023 · 1 comment
Labels
bug

Comments

@dkhalanskyjb
Copy link
Collaborator

See #3924 (comment)

This code produces 1, 2, 3:

@Test
fun foo() {
    GlobalScope.launch(Dispatchers.IO) {
        withContext(Dispatchers.Main.immediate) {
            println("1")
            launch(Dispatchers.Main) {
                println("2")
            }
            withContext(Dispatchers.Main) {
                println("3")
            }
        }
    }
}

This code, however, produces 1, 3, 2:

@Test
fun foo() {
    GlobalScope.launch(Dispatchers.Main) { // <-- note the different dispatcher
        withContext(Dispatchers.Main.immediate) {
            println("1")
            launch(Dispatchers.Main) {
                println("2")
            }
            withContext(Dispatchers.Main) {
                println("3")
            }
        }
    }
}

This behavior may be surprising. For example, consider this pseudo-code:

fun updateUi() = scope.launch(Dispatchers.Main) { }

suspend fun readUiElement(): Int = withContext(Dispatchers.Main) { 1 }

fun update() = viewModelScope.launch {
  updateUi()
  cache = readUiElement()
}

Depending on whether update is called from the main thread, the block in updateUi will happen either earlier or later than readUiElement, even though visually, it seems like updateUi should happen earlier.

Notably, all the other implementations of Dispatchers.Main that we provide don't suffer from the same problem but instead consistently output 1, 2, 3 in both scenarios.
@dkhalanskyjb dkhalanskyjb mentioned this issue Dec 1, 2023
Merged
@dkhalanskyjb
Copy link
Collaborator Author

Fixed in 7f32340

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dkhalanskyjb