Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flowOn(Dispatchers.Main) does not change upstream dispatcher #3545

Closed
hoc081098 opened this issue Dec 2, 2022 · 1 comment
Closed

flowOn(Dispatchers.Main) does not change upstream dispatcher #3545

hoc081098 opened this issue Dec 2, 2022 · 1 comment
Assignees
@dkhalanskyjb
Labels
bug

Comments

@hoc081098
Copy link 

    flowOf(1)
      .onEach {
        Timber.d("timer: $it ${Thread.currentThread().name} ${currentCoroutineContext()[ContinuationInterceptor]}")
      }
      .flowOn(Dispatchers.Main)
      .onEach {
        Timber.d("timer [1]: $it ${Thread.currentThread().name} ${currentCoroutineContext()[ContinuationInterceptor]}")
      }
      .launchIn(viewModelScope)

// viewModelScope's context is SupervisorJob() + Dispatchers.Main.immediate

Console

timer: 1 main Dispatchers.Main.immediate
timer [1]: 1 main Dispatchers.Main.immediate
@hoc081098
Copy link
Author

hoc081098 commented Dec 2, 2022 •
edited
Loading

I saw Dispatchers.Main == Dispatchers.Main.immediate gives true (because they have the same Handler,

kotlinx.coroutines/ui/kotlinx-coroutines-android/src/HandlerDispatcher.kt

Line 175 in 6dfabf7

override fun equals(other: Any?): Boolean = other is HandlerContext && other.handler === handler
)

So

kotlinx.coroutines/kotlinx-coroutines-core/common/src/flow/internal/ChannelFlow.kt

Line 166 in 6dfabf7

if (newContext == collectContext)

will not change the context.

Is that expected behavior?

@qwwdfsad qwwdfsad added the bug label Dec 7, 2022
dkhalanskyjb added a commit that referenced this issue Nov 2, 2023
@dkhalanskyjb
Ensure Dispatchers.Main != Dispatchers.Main.immediate on Android
a01c727 
Fixes #3545
@dkhalanskyjb dkhalanskyjb mentioned this issue Nov 2, 2023
Merged
dkhalanskyjb added a commit that referenced this issue Nov 7, 2023
@dkhalanskyjb
Ensure Dispatchers.Main != Dispatchers.Main.immediate on Android
c5d1e5e 
Fixes #3545
dkhalanskyjb added a commit that referenced this issue Nov 28, 2023
@dkhalanskyjb
Ensure Dispatchers.Main != Dispatchers.Main.immediate on Android
accbd32 
Fixes #3545
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dkhalanskyjb dkhalanskyjb

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@qwwdfsad @hoc081098 @dkhalanskyjb