Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEBUG-IMPROVEMENT] expose job.parentJob #3201

Closed
revintec opened this issue Feb 22, 2022 · 1 comment
Closed

[DEBUG-IMPROVEMENT] expose job.parentJob #3201

revintec opened this issue Feb 22, 2022 · 1 comment
Assignees
@qwwdfsad
Labels
debug enhancement

Comments

@revintec
Copy link

revintec commented Feb 22, 2022 •
edited
Loading

currently job.parentJob is not exposed, making it harder to build a parent-child relational job graph when debug
according to this #3198 it should be fairly easy(and safe?) to expose that

(kotlinx.coroutines.JobSupport.parentHandle as ChildHandle).parent
@qwwdfsad qwwdfsad self-assigned this Jul 27, 2022
@qwwdfsad qwwdfsad added the debug label Jul 29, 2022
qwwdfsad added a commit that referenced this issue Jul 29, 2022
@qwwdfsad
Introduce Job.parent API
3fa715e 
* The API is crucial for debugger extension and deadlock detection
* It enables allows more fluent coroutines hierarchy inspection, e.g. capability to build a list of roots and procrss them top-bottom separately

Fixes #3201
@qwwdfsad qwwdfsad mentioned this issue Jul 29, 2022
Merged
@dovchinnikov
Copy link
Contributor

This might be needed to be re-evaluated in light of #814

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qwwdfsad qwwdfsad

Labels
debug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@qwwdfsad @dovchinnikov @revintec