-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove @FlowPreview on (() ->T).asFlow()
and (suspend () -> T).asFlow()
#3097
Comments
We can gradually promote them to experimental. Our original concern was top-level scope pollution, but it seems like it doesn't bother anyone. Could you please elaborate on your usages of these extensions? |
What does this answer mean? Can we remove FlowPreview? |
Can v1.7 remove it? |
Yeah, can we remove it? |
Just wanted to share that I added this to my app level
This allowed me to remove all the annotations in my code without any complaints or warnings from the IDE. When FlowPreview is eventually removed, I can just remove it from here. |
It's not clear to me, without the compiler flags... can/should it be removed? |
Can someone write some motivation to remove |
With annotations like |
It is useful to convert a lambda to Flow, without suspend fun fetchApi(): Response
fetcherFlow
.flatMapLatest { ::fetchApi.asFlow() }
.collect { ... } |
For this particular snippet, I'd argue that you can use |
@mhernand40 of course, since it is a simple demo. When we use suspend fun fetchApi(): Response
fetcherFlow
.flatMapLatest {
::fetchApi.asFlow()
.map { LCE.Success(it) }
.onStart { emit(LCE.Loading) }
.catch { emit(LCE.Error(it)) }
}
.collect { ... } |
I notice @FlowPreview has been removed on all extensions
###.asFlow()
except() -> T
andsuspend () -> T
. Can we remove it on them?The text was updated successfully, but these errors were encountered: