Introduce ClassValue-based exception constructor cache to stracktrace recovery #2997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwwdfsad
force-pushed
the
class-value-exception-ctor
branch
2 times, most recently
from
5a9be61 to
746cd00
Compare
… recovery * It eliminates the classloader leak in containerized environments * Insignificantly improves performance of exception copying * Creates a precedent of guarded use of non Android-compliant API
qwwdfsad
force-pushed
the
class-value-exception-ctor
branch
from
746cd00 to
999a4a2
Compare
dkhalanskyjb
approved these changes
Nov 16, 2021
kotlinx-coroutines-core/jvm/src/internal/ExceptionsConstructor.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: dkhalanskyjb <52952525+dkhalanskyjb@users.noreply.github.com>
yorickhenning
pushed a commit
to yorickhenning/kotlinx.coroutines
that referenced
this pull request
Jan 28, 2022
… recovery (Kotlin#2997) * Use ClassValue-based cache for exception constructors with stacktrace recovery * It eliminates the classloader leak in containerized environments * Insignificantly improves the performance of exception copying * Creates a precedent of guarded use of non-Android-compliant API Co-authored-by: dkhalanskyjb <52952525+dkhalanskyjb@users.noreply.github.com>
pablobaxter
pushed a commit
to pablobaxter/kotlinx.coroutines
that referenced
this pull request
Sep 14, 2022
… recovery (Kotlin#2997) * Use ClassValue-based cache for exception constructors with stacktrace recovery * It eliminates the classloader leak in containerized environments * Insignificantly improves the performance of exception copying * Creates a precedent of guarded use of non-Android-compliant API Co-authored-by: dkhalanskyjb <52952525+dkhalanskyjb@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When it's available.
The change has two purposes:
ClassLoaderleak-free implementation ofExceptionsConstructor