Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BlockHound false positives in ConflatedChannel #2866

Closed
OliverO2 opened this issue Aug 10, 2021 · 0 comments
Closed

BlockHound false positives in ConflatedChannel #2866

OliverO2 opened this issue Aug 10, 2021 · 0 comments
Labels
bug

Comments

@OliverO2
Copy link
Contributor

I have seen BlockHound complaining on a blocking call on jdk.internal.misc.Unsafe#park apparently caused by:

kotlinx.coroutines.channels.ConflatedChannel.enqueueReceiveInternal

Seems like a false positive. Unfortunately, I have not been able to reproduce it.

Probably it is worth adding "isEmpty" and "enqueueReceiveInternal" to the list in allowBlockingCallsInConflatedChannel(), as both of them use the same lock as the other members, but are not covered yet:

kotlinx.coroutines/kotlinx-coroutines-debug/src/CoroutinesBlockHoundIntegration.kt

Lines 135 to 136 in 7e762d3

for (method in listOf("offerInternal", "offerSelectInternal", "pollInternal", "pollSelectInternal",
"onCancelIdempotent"))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@qwwdfsad @OliverO2