Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make DisposableHandle fun interface, remove our own adapter #2790

Merged
merged 1 commit into from
Sep 3, 2021
Merged

Make DisposableHandle fun interface, remove our own adapter #2790

merged 1 commit into from
Sep 3, 2021

Conversation

qwwdfsad
Copy link
Contributor

It was internal and was not part of the ABI as it was internal.
So no existing code should break (well, except for those who called internal API via reflection) and source compatibility is preserved

@qwwdfsad qwwdfsad requested a review from dkhalanskyjb June 25, 2021 09:27
dkhalanskyjb
dkhalanskyjb approved these changes Jun 25, 2021
View reviewed changes
Copy link
Collaborator

@dkhalanskyjb dkhalanskyjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked to the best of my ability, and it does look like source-level compatibility is preserved.

@qwwdfsad
Copy link
Contributor Author

Seems that ::DisposableHandle is not supported for fun interfaces, so let's postpone it for a while

@qwwdfsad qwwdfsad merged commit 61acb95 into develop Sep 3, 2021
@qwwdfsad qwwdfsad deleted the make-dh-fun branch September 3, 2021 16:16
@hfhbd hfhbd mentioned this pull request Nov 23, 2021
Closed
pablobaxter pushed a commit to pablobaxter/kotlinx.coroutines that referenced this pull request Sep 14, 2022
@qwwdfsad @pablobaxter
Make DisposableHandle fun interface, remove our own adapter (Kotlin#2790
5ad4285 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkhalanskyjb dkhalanskyjb dkhalanskyjb approved these changes

Assignees
No one assigned
Labels
For 1.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qwwdfsad @dkhalanskyjb