Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Provide inline overloads of terminal operators returning Nothing for SharedFlow #2502

Closed
LouisCAD opened this issue Jan 27, 2021 · 2 comments
Closed

Proposal: Provide inline overloads of terminal operators returning Nothing for SharedFlow #2502

LouisCAD opened this issue Jan 27, 2021 · 2 comments
Labels
enhancement flow

Comments

@LouisCAD
Copy link
Contributor

That would make it easier to mark functions that never return (responding only to cancellation after being called) because they collect an infinite flow.
@LouisCAD
Copy link
Contributor Author

Should I send a PR?

@qwwdfsad qwwdfsad added the flow label Jun 8, 2021
@qwwdfsad
Copy link
Contributor

Sure 👍

qwwdfsad added a commit that referenced this issue Jul 1, 2021
@qwwdfsad
Introduce SharedFlow collect overload and override that return Nothing
53669a8 
    * Override will ensure the proper implementation of the interface
    * collect extension is added as the very basic lint helper

Fixes #2789
Fixes #2502
@qwwdfsad qwwdfsad mentioned this issue Jul 1, 2021
Merged
yorickhenning pushed a commit to yorickhenning/kotlinx.coroutines that referenced this issue Jan 28, 2022
@qwwdfsad @dkhalanskyjb @yorickhenning
Introduce SharedFlow collect overload and override that return Nothing (
103e3d5 
Kotlin#2803)

* Introduce SharedFlow collect overload and override that return Nothing
* Override will ensure the proper implementation of the interface
* collect extension is added as the very basic lint helper

Fixes Kotlin#2789
Fixes Kotlin#2502

Co-authored-by: dkhalanskyjb <52952525+dkhalanskyjb@users.noreply.github.com>
pablobaxter pushed a commit to pablobaxter/kotlinx.coroutines that referenced this issue Sep 14, 2022
@qwwdfsad @dkhalanskyjb @pablobaxter
Introduce SharedFlow collect overload and override that return Nothing (
7ae4baa 
Kotlin#2803)

* Introduce SharedFlow collect overload and override that return Nothing
* Override will ensure the proper implementation of the interface
* collect extension is added as the very basic lint helper

Fixes Kotlin#2789
Fixes Kotlin#2502

Co-authored-by: dkhalanskyjb <52952525+dkhalanskyjb@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement flow
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@qwwdfsad @LouisCAD