feat: Support bold Fraktur #3777

ronkok · 2023-01-18T19:18:10Z

Support bold Fraktur. Resolves #3776.

Note: KaTeX has a font for bold Fraktur, but no font metrics. That is why I left bold Fraktur out of the original PR for wide-character Unicode support. In this PR, I evade the lack of metrics by using the font metrics for regular Fraktur, not bold Fraktur.

ronkok · 2023-01-18T21:47:08Z

The second commit makes this PR more general in addressing the complaint of issue #3776. The results of function wideCharacterFont() are no longer used when inapplicable. That avoids all the bad error messages that would come from inapplicable use.

codecov · 2023-01-18T21:47:25Z

Codecov Report

Merging #3777 (29ee8da) into main (4f1d916) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3777   +/-   ##
=======================================
  Coverage   92.98%   92.99%           
=======================================
  Files          91       91           
  Lines        6773     6779    +6     
  Branches     1575     1576    +1     
=======================================
+ Hits         6298     6304    +6     
  Misses        437      437           
  Partials       38       38

Files	Coverage Δ
src/buildCommon.js	`96.94% <100.00%> (+0.03%)`	⬆️
src/symbols.js	`100.00% <100.00%> (ø)`
src/wide-character.js	`70.00% <ø> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f1d916...29ee8da. Read the comment docs.

edemaine

Sorry for the long delay in review here. Slowly getting back into things...

Overall, this seems like a good fix to bold Fraktur, so this PR should be probably be merged. However, I noticed one thing more generally about Fraktur support:

I just tested and \text{𝔄-ℨ} generates an error, because \u212D (Z), \u210C (H), and \u2128 (Z) are macro'd in src/macros.js to use \mathfrak but sometimes we want \textfrak. (Not sure why this doesn't generate an error when building the documentation. Perhaps it does and it's being silently ignored.)

Perhaps this is legacy code and can simply be removed?

KaTeX/src/macros.js

Lines 256 to 258 in 5dd9bc4

    
           defineMacro("\u212D", "\\mathfrak{C}");  // Fraktur 
        
           defineMacro("\u210C", "\\mathfrak{H}"); 
        
           defineMacro("\u2128", "\\mathfrak{Z}");

edemaine · 2023-06-19T19:28:52Z

P.S. I also looked into generating actual metrics for the bold Fraktur font. (Part of the delay.) My attempts failed, though, so I think this should go as is; we can consider adding them later if I figure out how metrics get built.

edemaine · 2023-06-19T23:37:43Z

src/buildCommon.js

+    const [wideFontName, wideFontClass] = text.charCodeAt(0) !== 0xD835
+      ? ["", ""]
+      : wideCharacterFont(text, mode);
+    if (wideFontName.length > 0) {


It would be nice to avoid the array creation in the negative case. How about this:

let wideFontName, wideFontClass; if (text.charCodeAt(0) === 0xD835) { [wideFontName, wideFontClass] = wideCharacterFont(text, mode); } if (wideFontName) {

edemaine · 2023-06-25T20:36:44Z

Perhaps this is legacy code and can simply be removed?

@ronkok Do you agree with this assessment? If so, I can remove the code and make the other requested change.

ronkok · 2023-06-25T21:20:33Z

Perhaps this is legacy code and can simply be removed?

I don't think that is correct. Most Fractur characters are outside the Unicode Basic Multilingual Plane (BMP). They are addressed by the wide character function modified in this PR.

But a few Fractur characters are in the BMP. KaTeX defines them in these macros.

KaTeX/src/macros.js

Lines 247 to 258 in ad03d1e

    
           // Characters omitted from Unicode range 1D400–1D7FF 
        
           defineMacro("\u212C", "\\mathscr{B}");  // script 
        
           defineMacro("\u2130", "\\mathscr{E}"); 
        
           defineMacro("\u2131", "\\mathscr{F}"); 
        
           defineMacro("\u210B", "\\mathscr{H}"); 
        
           defineMacro("\u2110", "\\mathscr{I}"); 
        
           defineMacro("\u2112", "\\mathscr{L}"); 
        
           defineMacro("\u2133", "\\mathscr{M}"); 
        
           defineMacro("\u211B", "\\mathscr{R}"); 
        
           defineMacro("\u212D", "\\mathfrak{C}");  // Fraktur 
        
           defineMacro("\u210C", "\\mathfrak{H}"); 
        
           defineMacro("\u2128", "\\mathfrak{Z}");

I suppose I could have instead defined them in symbols.js. That would probably be better than the macro method. It would be easier in symbols.js to define them both as a mathord and as a textord. The lack of a textord definition is causing the error.

I think a symbols.js definition of the BMP characters should be located below the loop where wide character Frakturs are defined.

KaTeX/src/symbols.js

Lines 815 to 817 in ad03d1e

    
           wideChar = String.fromCharCode(0xD835, 0xDD04 + i);  // A-Z a-z Fractur 
        
           defineSymbol(math, main, mathord, ch, wideChar); 
        
           defineSymbol(text, main, textord, ch, wideChar);

Then the BMP definitions would overwrite the first definition.

…ldFraktur

## [0.16.9](v0.16.8...v0.16.9) (2023-10-02) ### Features * Support bold Fraktur ([#3777](#3777)) ([240d5ae](240d5ae))

KaTeX-bot · 2023-10-02T20:11:36Z

🎉 This PR is included in version 0.16.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

feat: Support bold Fraktur

23aad26

ronkok mentioned this pull request Jan 18, 2023

"Font metrics not found for font" error #3776

Closed

Evade wideCharacterFont() when inapplicable

3c4d289

edemaine added 2 commits May 29, 2023 15:03

Merge branch 'main' into boldFraktur

99d1e94

Merge branch 'main' into boldFraktur

ba1ecad

edemaine approved these changes Jun 19, 2023

View reviewed changes

edemaine reviewed Jun 19, 2023

View reviewed changes

ronkok added 3 commits October 2, 2023 10:15

Merge branch 'main' into boldFraktur

0f772b6

Merge branch 'boldFraktur' of https://github.com/ronkok/KaTeX into bo…

4a199d5

…ldFraktur

Avoid creating array when uneccesary

29ee8da

ronkok merged commit 240d5ae into KaTeX:main Oct 2, 2023

ronkok deleted the boldFraktur branch October 2, 2023 20:07

KaTeX-bot added a commit that referenced this pull request Oct 2, 2023

chore(release): 0.16.9 [ci skip]

5ac899e

## [0.16.9](v0.16.8...v0.16.9) (2023-10-02) ### Features * Support bold Fraktur ([#3777](#3777)) ([240d5ae](240d5ae))

KaTeX-bot added the released label Oct 2, 2023

untitledunrevised mentioned this pull request Oct 5, 2023

Unable to render Fractur 'Z' under text mode #3867

Closed

3 tasks

AnushaSalian mentioned this pull request May 24, 2024

[Snyk] Upgrade katex from 0.16.4 to 0.16.10 virtual-labs/ph3-lab-mgmt#441

Open

AnushaSalian mentioned this pull request Jul 19, 2024

[Snyk] Upgrade katex from 0.16.4 to 0.16.10 virtual-labs/ph3-lab-mgmt#478

Open

X-oss-byte mentioned this pull request Jul 23, 2024

[Snyk] Upgrade katex from 0.12.0 to 0.16.11 X-oss-byte/gatsby-1#797

Open

AnushaSalian mentioned this pull request Jul 24, 2024

[Snyk] Upgrade katex from 0.16.4 to 0.16.11 virtual-labs/ph3-lab-mgmt#485

Open

ASISBusiness mentioned this pull request Aug 16, 2024

[Snyk] Upgrade katex from 0.12.0 to 0.16.11 ASISBusiness/specs#1

Open

This was referenced Sep 13, 2024

[Snyk] Upgrade: vue, katex, highlight.js, markdown-it, naive-ui, pinia, vue-i18n, vue-router yexiaoyu123/ChatGPT-Web#33

Open

[Snyk] Upgrade: vue, katex, highlight.js, markdown-it, naive-ui, pinia, vue-i18n, vue-router yexiaoyu123/ChatGPT-Web#34

Open

yexiaoyu123 mentioned this pull request Sep 23, 2024

[Snyk] Upgrade: vue, katex, highlight.js, markdown-it, naive-ui, pinia, vue-i18n, vue-router yexiaoyu123/ChatGPT-Web#35

Open

kazup01 mentioned this pull request Sep 28, 2024

[Snyk] Upgrade katex from 0.6.0 to 0.16.11 kazup01/Boostnote#1

Open

AnushaSalian mentioned this pull request Oct 8, 2024

[Snyk] Upgrade katex from 0.16.4 to 0.16.11 virtual-labs/ph3-lab-mgmt#553

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Support bold Fraktur #3777

feat: Support bold Fraktur #3777

ronkok commented Jan 18, 2023 •

edited by edemaine

Loading

ronkok commented Jan 18, 2023

codecov bot commented Jan 18, 2023 •

edited

Loading

edemaine left a comment

edemaine commented Jun 19, 2023

edemaine Jun 19, 2023

ronkok Jun 20, 2023

edemaine commented Jun 25, 2023

ronkok commented Jun 25, 2023

KaTeX-bot commented Oct 2, 2023

	defineMacro("\u212D", "\\mathfrak{C}"); // Fraktur
	defineMacro("\u210C", "\\mathfrak{H}");
	defineMacro("\u2128", "\\mathfrak{Z}");

feat: Support bold Fraktur #3777

feat: Support bold Fraktur #3777

Conversation

ronkok commented Jan 18, 2023 • edited by edemaine Loading

ronkok commented Jan 18, 2023

codecov bot commented Jan 18, 2023 • edited Loading

Codecov Report

edemaine left a comment

Choose a reason for hiding this comment

edemaine commented Jun 19, 2023

edemaine Jun 19, 2023

Choose a reason for hiding this comment

ronkok Jun 20, 2023

Choose a reason for hiding this comment

edemaine commented Jun 25, 2023

ronkok commented Jun 25, 2023

KaTeX-bot commented Oct 2, 2023

ronkok commented Jan 18, 2023 •

edited by edemaine

Loading

codecov bot commented Jan 18, 2023 •

edited

Loading