Correctly merge ExposedDropdownMenu from Material 3 1.3
#1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-sasha
reviewed
Jun 28, 2024
| @@ -107,7 +108,7 @@ internal fun TextFieldWithExposedDropdown() { | |||
| onExpandedChange = { expanded = !expanded }, | |||
| ) { | |||
| TextField( | |||
| modifier = Modifier.menuAnchor(), | |||
| modifier = Modifier.menuAnchor(MenuAnchorType.PrimaryNotEditable), | |||
There was a problem hiding this comment.
Maybe add examples of the other two MenuAnchorTypes.
There was a problem hiding this comment.
Yeah, we have a lot of new elements that should be tested/covered. Let's do it separately from the merge (and fixing bad merge)
m-sasha
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing changes during Material 3 1.3 merge
Fixes JetBrains/compose-multiplatform#4782
Fixes JetBrains/compose-multiplatform#5033
Release Notes
Fixes - Multiple Platforms
TextFieldinsideExposedDropdownMenuBox