Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the code from 'await author.save()' to 'await story1.save()' … #13596

Merged
merged 3 commits into from
Jul 12, 2023
Merged

Changed the code from 'await author.save()' to 'await story1.save()' … #13596

merged 3 commits into from
Jul 12, 2023

Conversation

SomSingh23
Copy link
Contributor

This pull request resolves the issue in the 'docs/populate.md' file.

It replaces 'await author.save()' with 'await story1.save()' for clarity and correctness.

The motivation behind this change is to ensure that readers and code implementers encounter no errors while following the documentation and implementing the code simultaneously.

image

Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual await story1.save(); change is LGTM, but there's a bunch of unrelated changes in this PR. Looks like you're using some sort of code formatter that is automatically changing single quotes to double quotes and adding trailing commas: can you please undo all unrelated changes?

@SomSingh23
Copy link
Contributor Author

The actual await story1.save(); change is LGTM, but there's a bunch of unrelated changes in this PR. Looks like you're using some sort of code formatter that is automatically changing single quotes to double quotes and adding trailing commas: can you please undo all unrelated changes?

yeah definitely

@SomSingh23
Copy link
Contributor Author

@vkarpov15 I have made some modifications to the code. Could you please take a look at it?

@SomSingh23
Copy link
Contributor Author

SomSingh23 commented Jul 11, 2023 via email

@SomSingh23 SomSingh23 requested a review from vkarpov15 July 12, 2023 13:56
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks 👍

@vkarpov15 vkarpov15 added this to the 7.4.0 milestone Jul 12, 2023
@vkarpov15 vkarpov15 merged commit eeefdd2 into Automattic:master Jul 12, 2023
@SomSingh23
Copy link
Contributor Author

Thank you for merging my pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants