-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed the code from 'await author.save()' to 'await story1.save()' … #13596
Conversation
…inside the 'docs/populate.md' file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The actual await story1.save();
change is LGTM, but there's a bunch of unrelated changes in this PR. Looks like you're using some sort of code formatter that is automatically changing single quotes to double quotes and adding trailing commas: can you please undo all unrelated changes?
yeah definitely |
@vkarpov15 I have made some modifications to the code. Could you please take a look at it? |
@vkarpov15, I have made some modifications to the code, specifically
removing all unrelated changes. Would you mind taking a look at it, please?
…On Wed, 12 Jul, 2023, 12:38 am Valeri Karpov, ***@***.***> wrote:
***@***.**** requested changes on this pull request.
The actual await story1.save(); change is LGTM, but there's a bunch of
unrelated changes in this PR. Looks like you're using some sort of code
formatter that is automatically changing single quotes to double quotes and
adding trailing commas: can you please undo all unrelated changes?
—
Reply to this email directly, view it on GitHub
<#13596 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AVZ7I6NRCRBE45F55J24IVTXPWQCFANCNFSM6AAAAAA2E32BYM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks 👍
Thank you for merging my pull request. |
This pull request resolves the issue in the 'docs/populate.md' file.
It replaces 'await author.save()' with 'await story1.save()' for clarity and correctness.
The motivation behind this change is to ensure that readers and code implementers encounter no errors while following the documentation and implementing the code simultaneously.