feat(connection): add Connection.prototype.removeDb() for removing a related connection
#13580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a related connection Fix #11821
hasezoey
reviewed
Jul 5, 2023
Co-authored-by: hasezoey <hasezoey@gmail.com>
|
@hasezoey can you please re-review? |
hasezoey
approved these changes
Jul 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11821
Summary
Right now there's no clean way to close a
useDb()connection, you have to reach into internals and remove the db fromrelatedDbs, etc. With this PR,removeDb()lets you permanently close auseDb()connection so it can be garbage collected: removes it fromrelatedDbs,otherDbs, and marks the db as force closed and destroyed, so any collection operations immediately error out.Examples