Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Update swc_core to v10.5.0 #75098

Merged
merged 2 commits into from
Jan 20, 2025
Merged

build: Update swc_core to v10.5.0 #75098

merged 2 commits into from
Jan 20, 2025

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jan 20, 2025 •
edited by padmaia
Loading

@kdy1 kdy1 requested a review from a team January 20, 2025 10:49
@kdy1 kdy1 self-assigned this Jan 20, 2025
@ijjk ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Jan 20, 2025
@ijjk
Copy link
Member

ijjk commented Jan 20, 2025 •
edited
Loading

Failing test suites

Commit: 71ffac6

pnpm test test/integration/amp-export-validation/test/index.test.js (turbopack)

  • AMP Validation on Export > production mode > should have shown errors during build
Expand output

● AMP Validation on Export › production mode › should have shown errors during build

expect(received).toMatch(expected)

Expected pattern: /error.*The mandatory attribute 'height' is missing in tag 'amp-video'\./
Received string:  "   Loading config from /root/actions-runner/_work/next.js/next.js/test/integration/amp-export-validation/next.config.js
   Loading config from /root/actions-runner/_work/next.js/next.js/test/integration/amp-export-validation/next.config.js
   ▲ Next.js 15.2.0-canary.16 (Turbopack)·
   Checking validity of types ...
   Creating an optimized production build ...
   Loading config from /root/actions-runner/_work/next.js/next.js/test/integration/amp-export-validation/next.config.js
   Building (0/7) ...
   Building (1/7)··
   Building (3/7)··
   Building (5/7)··
 ✓ Building (7/7)
 ✓ Compiled successfully in 2.4s
   Collecting page data ...
   Generating static pages (0/8) ...
   Generating static pages (2/8)··
 ⚠ Linting is disabled.
Error occurred prerendering page \"/first\". Read more: https://nextjs.org/docs/messages/prerender-error
AssertionError: Assertion failed: WebAssembly is uninitialized

  at new module$contents$goog$asserts_AssertionError (../evalmachine.<anonymous>:106:1695)
  at module$contents$goog$asserts_doAssertFailure (../evalmachine.<anonymous>:107:354)
  at goog.asserts.assertExists (../evalmachine.<anonymous>:109:142)
  at Object.module$contents$amp$validator_validateString [as validateString] (../evalmachine.<anonymous>:2663:108)
  at Validator.validateString (../packages/next/dist/compiled/amphtml-validator/index.js:1:20650)
  at validateAmp (../packages/next/dist/export/routes/pages.js:87:34)
  at async exportPagesPage (../packages/next/dist/export/routes/pages.js:104:13)
  at async Span.traceAsyncFn (../packages/next/dist/trace/trace.js:156:20)
  at async exportPage (../packages/next/dist/export/worker.js:345:18)
  Export encountered an error on /first, exiting the build.
   ⨯ Static worker exited with code: 1 and signal: null
  "
  at Object.toMatch (integration/amp-export-validation/test/index.test.js:28:29)

Read more about building and testing Next.js in contributing.md.

@ijjk
Copy link
Member

ijjk commented Jan 20, 2025 •
edited
Loading

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary vercel/next.js kdy1/swc-core-10-4 Change
buildDuration 19.7s 15.2s N/A
buildDurationCached 15.4s 12.2s N/A
nodeModulesSize 418 MB 418 MB N/A
nextStartRea..uration (ms) 447ms 424ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js kdy1/swc-core-10-4 Change
5306-HASH.js gzip 54 kB 54 kB N/A
8276.HASH.js gzip 169 B 168 B N/A
8377-HASH.js gzip 5.44 kB 5.44 kB N/A
bccd1874-HASH.js gzip 52.9 kB 52.9 kB ✓
framework-HASH.js gzip 57.5 kB 57.5 kB N/A
main-app-HASH.js gzip 240 B 242 B N/A
main-HASH.js gzip 34.4 kB 34.4 kB N/A
webpack-HASH.js gzip 1.71 kB 1.71 kB N/A
Overall change 52.9 kB 52.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js kdy1/swc-core-10-4 Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Overall change 39.4 kB 39.4 kB ✓
Client Pages
vercel/next.js canary vercel/next.js kdy1/swc-core-10-4 Change
_app-HASH.js gzip 193 B 193 B ✓
_error-HASH.js gzip 193 B 193 B ✓
amp-HASH.js gzip 512 B 510 B N/A
css-HASH.js gzip 343 B 342 B N/A
dynamic-HASH.js gzip 1.84 kB 1.84 kB ✓
edge-ssr-HASH.js gzip 265 B 265 B ✓
head-HASH.js gzip 363 B 362 B N/A
hooks-HASH.js gzip 393 B 392 B N/A
image-HASH.js gzip 4.57 kB 4.57 kB N/A
index-HASH.js gzip 268 B 268 B ✓
link-HASH.js gzip 2.35 kB 2.34 kB N/A
routerDirect..HASH.js gzip 328 B 328 B ✓
script-HASH.js gzip 397 B 397 B ✓
withRouter-HASH.js gzip 323 B 326 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Overall change 3.59 kB 3.59 kB ✓
Client Build Manifests
vercel/next.js canary vercel/next.js kdy1/swc-core-10-4 Change
_buildManifest.js gzip 749 B 747 B N/A
Overall change 0 B 0 B ✓
Rendered Page Sizes
vercel/next.js canary vercel/next.js kdy1/swc-core-10-4 Change
index.html gzip 524 B 524 B ✓
link.html gzip 539 B 536 B N/A
withRouter.html gzip 520 B 520 B ✓
Overall change 1.04 kB 1.04 kB ✓
Edge SSR bundle Size
vercel/next.js canary vercel/next.js kdy1/swc-core-10-4 Change
edge-ssr.js gzip 129 kB 129 kB N/A
page.js gzip 208 kB 208 kB N/A
Overall change 0 B 0 B ✓
Middleware size
vercel/next.js canary vercel/next.js kdy1/swc-core-10-4 Change
middleware-b..fest.js gzip 670 B 667 B N/A
middleware-r..fest.js gzip 155 B 156 B N/A
middleware.js gzip 31.3 kB 31.3 kB N/A
edge-runtime..pack.js gzip 844 B 844 B ✓
Overall change 844 B 844 B ✓
Next Runtimes
vercel/next.js canary vercel/next.js kdy1/swc-core-10-4 Change
274-experime...dev.js gzip 322 B 322 B ✓
274.runtime.dev.js gzip 314 B 314 B ✓
app-page-exp...dev.js gzip 375 kB 375 kB ✓
app-page-exp..prod.js gzip 130 kB 130 kB ✓
app-page-tur..prod.js gzip 143 kB 143 kB ✓
app-page-tur..prod.js gzip 139 kB 139 kB ✓
app-page.run...dev.js gzip 363 kB 363 kB ✓
app-page.run..prod.js gzip 126 kB 126 kB ✓
app-route-ex...dev.js gzip 37.6 kB 37.6 kB ✓
app-route-ex..prod.js gzip 25.6 kB 25.6 kB ✓
app-route-tu..prod.js gzip 25.6 kB 25.6 kB ✓
app-route-tu..prod.js gzip 25.4 kB 25.4 kB ✓
app-route.ru...dev.js gzip 39.2 kB 39.2 kB ✓
app-route.ru..prod.js gzip 25.4 kB 25.4 kB ✓
pages-api-tu..prod.js gzip 9.69 kB 9.69 kB ✓
pages-api.ru...dev.js gzip 11.6 kB 11.6 kB ✓
pages-api.ru..prod.js gzip 9.68 kB 9.68 kB ✓
pages-turbo...prod.js gzip 21.9 kB 21.9 kB ✓
pages.runtim...dev.js gzip 27.7 kB 27.7 kB ✓
pages.runtim..prod.js gzip 21.9 kB 21.9 kB ✓
server.runti..prod.js gzip 916 kB 916 kB ✓
Overall change 2.47 MB 2.47 MB ✓
build cache Overall increase ⚠️
vercel/next.js canary vercel/next.js kdy1/swc-core-10-4 Change
0.pack gzip 2.1 MB 2.1 MB N/A
index.pack gzip 74.8 kB 75.3 kB ⚠️ +539 B
Overall change 74.8 kB 75.3 kB ⚠️ +539 B
Diff details
Diff for main-HASH.js

Diff too large to display

Commit: 71ffac6

@kdy1 kdy1 enabled auto-merge (squash) January 20, 2025 12:36
@kdy1 kdy1 force-pushed the kdy1/swc-core-10-4 branch from f667ffb to 71ffac6 Compare January 20, 2025 13:04
@kdy1 kdy1 disabled auto-merge January 20, 2025 13:38
@kdy1 kdy1 enabled auto-merge (squash) January 20, 2025 13:52
@kdy1 kdy1 merged commit a7ac453 into canary Jan 20, 2025
130 checks passed
@kdy1 kdy1 deleted the kdy1/swc-core-10-4 branch January 20, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mischnic mischnic mischnic approved these changes

Assignees

@kdy1 kdy1

Labels
created-by: Turbopack team PRs by the Turbopack team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kdy1 @ijjk @mischnic