Atmospheres Refactor Take 2 #4099
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also updated and fixed. |
Imaginos16
added
Test Merge Candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Re-attempt of #3878.
Basically makes atmosphere gas string generation a lot better. The previous method was baffling to me and it bugged me to no end. This was intended to be part of a bigger PR but I might as well PR this as it is now.
Calculations of randomized atmos mixes WILL be different now, but I tried to make it as similar to the old method as I could without bending over backwards. We'll get used to it, unless it's bugged.
Also gets rid of
initial_temperatureon turfs, because it literally did nothing. Specify temperature as part ofinitial_gas_mix.Why It's Good For The Game
Simplifies an EXTREMELY needlessly complicated process that did something as simple as generating a "random" gas string for planets to use. Allows me to feel less bad when I generate a lot more unique atmosphere types.
Changelog
🆑
/:cl: