Introduce Dev only module for relevant extensions #45053

phillip-kruger · 2024-12-11T06:11:52Z

This is on top of the work that @aloubyansky did to allow Conditional dependency based on mode (dev mode in this case)

For now I only moved Dev UI Runtime to these new modules.
With some more refactoring we can move other things like HotReload setup and Dev console (I'll try that in another PR)

This PR is fairly big, but there is a commit per extension to make it easier to review. Basically it is the following for each extension:

Created a new module for runtime dev
Added this new module to the bom
Add this new module as a dependency in the deployment module
Add the conditional dependency in the runtime module (see https://quarkus.io/version/main/guides/conditional-extension-dependencies#dev-mode-dependencies-on-regular-maven-artifacts)
Move any dev ui runtime code to the new module

This means that all bits of dev ui is now removed from a Prod build. Previously the dev ui runtime classes was still part of the final bundle (even though they where not use internally, if users wanted they can create new instances of these classes)

quarkus-bot · 2024-12-11T06:13:55Z

/cc @gsmet (hibernate-orm,hibernate-search), @marko-bekhta (hibernate-search), @yrodiere (hibernate-orm,hibernate-search)

github-actions · 2024-12-11T06:43:43Z

🎊 PR Preview cd1579f has been successfully built and deployed to https://quarkus-pr-main-45053-preview.surge.sh/version/main/guides/

Images of blog posts older than 3 months are not available.
Newsletters older than 3 months are not available.

aloubyansky · 2024-12-11T08:50:28Z

The changes seem to look good but we need to check the failures

aloubyansky · 2024-12-11T12:00:46Z

I'll check why this failed

aloubyansky · 2024-12-11T12:36:26Z

We need 8583576 for this CI

aloubyansky · 2024-12-11T12:41:03Z

Basically, we need to merge #43618 and rebase

phillip-kruger · 2024-12-11T21:43:34Z

Failures are similar to what we had in #43618 so once #43618 is merged I'll rebase this and we should have a green CI

phillip-kruger · 2025-01-06T20:51:53Z

@aloubyansky please have a look at the failures. I rebased on main

Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>

…ch extension Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>

…nsion Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>

Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>

aloubyansky · 2025-01-07T07:41:44Z

@phillip-kruger you keep loosing my changes when you rebase. There are more failures than before. I'll rebase and force push. However, the Gradle failures will be challenging to fix. They are not related to dev mode-only dependencies but conditional dependencies in general. See my previous comment.

quarkus-bot · 2025-01-07T08:14:50Z

Status for workflow `Quarkus Documentation CI`

This is the status report for running Quarkus Documentation CI on commit 6406988.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Warning

There are other workflow runs running, you probably need to wait for their status before merging.

quarkus-bot · 2025-01-07T09:59:48Z

Status for workflow `Quarkus CI`

This is the status report for running Quarkus CI on commit 6406988.

Failing Jobs

Status	Name	Step	Failures	Logs	Raw logs	Build scan
✔️	Maven Tests - JDK 17			Logs	Raw logs	🔍
✖	Maven Tests - JDK 17 Windows	`Build`	Failures	Logs	Raw logs	🔍
✖	Gradle Tests - JDK 17	`Build`	Failures	Logs	Raw logs	🔍
✖	Gradle Tests - JDK 17 Windows	`Build`	Failures	Logs	Raw logs	🚧

Full information is available in the Build summary check run.
You can consult the Develocity build scans.

Failures

⚙️ Maven Tests - JDK 17 Windows #

- Failing: integration-tests/maven

📦 integration-tests/maven

✖ io.quarkus.maven.it.RemoteDevMojoIT.testThatApplicationRecoversCompilationIssue line 166 - History - More details - Source on GitHub

java.lang.RuntimeException: org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase.runAndCheck(RunAndCheckWithAgentMojoTestBase.java:86)
	at io.quarkus.maven.it.RemoteDevMojoIT.testThatApplicationRecoversCompilationIssue(RemoteDevMojoIT.java:166)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)

✖ io.quarkus.maven.it.RemoteDevMojoIT.testThatApplicationRecoversCompilationIssue line 166 - History - More details - Source on GitHub

java.lang.RuntimeException: org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase.runAndCheck(RunAndCheckWithAgentMojoTestBase.java:86)
	at io.quarkus.maven.it.RemoteDevMojoIT.testThatApplicationRecoversCompilationIssue(RemoteDevMojoIT.java:166)
	at java.base/java.lang.reflect.Method.invoke(Method.java:569)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
Caused by: org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.maven.it.RunAndCheckWithAgentMojoTestBase was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)

✖ io.quarkus.maven.it.RemoteDevMojoIT.testThatNewBeanAreDiscovered line 231 - History - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:164)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:155)

✖ io.quarkus.maven.it.RemoteDevMojoIT.testThatNewBeanAreDiscovered line 231 - History - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:164)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:155)

✖ io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnConfigChange line 102 - History - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 5 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:97)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:88)

✖ io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnConfigChange line 102 - History - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 5 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:97)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:88)

✖ io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnJavaChange line 44 - History - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:164)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:155)

✖ io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnJavaChange line 44 - History - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:164)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:155)

✖ io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnNewResource line 92 - History - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:164)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:155)

✖ io.quarkus.maven.it.RemoteDevMojoIT.testThatTheApplicationIsReloadedOnNewResource line 92 - History - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:164)
	at io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:155)

⚙️ Gradle Tests - JDK 17 #

- Failing: integration-tests/gradle

📦 integration-tests/gradle

✖ io.quarkus.gradle.devmode.MavenExclusionInExtensionDependencyDevModeTest.main - History - More details - Source on GitHub

java.lang.AssertionError: 
Expecting actual:
  "BROKEN: quarkusDev mode has terminated"
to contain:
  "Hello" 
	at app//io.quarkus.gradle.devmode.MavenExclusionInExtensionDependencyDevModeTest.testDevMode(MavenExclusionInExtensionDependencyDevModeTest.java:25)
	at app//io.quarkus.gradle.devmode.QuarkusDevGradleTestBase.main(QuarkusDevGradleTestBase.java:60)
	at java.base@17.0.13/java.lang.reflect.Method.invoke(Method.java:569)

⚙️ Gradle Tests - JDK 17 Windows #

📦 integration-tests/gradle

✖ io.quarkus.gradle.devmode.BasicCompositeBuildExtensionProjectDevModeTest.main - History - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 5 minutes.
	at app//org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at app//io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:97)
	at app//io.quarkus.gradle.devmode.QuarkusDevGradleTestBase.getHttpResponse(QuarkusDevGradleTestBase.java:156)

✖ io.quarkus.gradle.devmode.BasicCompositeBuildProjectDevModeTest.main - History - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 5 minutes.
	at app//org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at app//io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:97)
	at app//io.quarkus.gradle.devmode.QuarkusDevGradleTestBase.getHttpResponse(QuarkusDevGradleTestBase.java:156)

✖ io.quarkus.gradle.devmode.BasicJavaLibraryModuleDevModeTest.main - History - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 5 minutes.
	at app//org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at app//io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:97)
	at app//io.quarkus.gradle.devmode.QuarkusDevGradleTestBase.getHttpResponse(QuarkusDevGradleTestBase.java:156)

✖ io.quarkus.gradle.devmode.BasicMultiModuleProjectDevModeTest.main - History - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 5 minutes.
	at app//org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at app//io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:97)
	at app//io.quarkus.gradle.devmode.QuarkusDevGradleTestBase.getHttpResponse(QuarkusDevGradleTestBase.java:156)

✖ io.quarkus.gradle.devmode.CompileOnlyDependencyDevModeTest.main - History - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 2 minutes.
	at app//org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at app//io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:164)
	at app//io.quarkus.gradle.devmode.QuarkusDevGradleTestBase.getHttpResponse(QuarkusDevGradleTestBase.java:164)

✖ io.quarkus.gradle.devmode.JandexKordampMultiModuleProjectDevModeTest.main - History - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes  30 seconds.
	at app//org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at app//io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:164)
	at app//io.quarkus.gradle.devmode.QuarkusDevGradleTestBase.getHttpResponse(QuarkusDevGradleTestBase.java:164)

✖ io.quarkus.gradle.devmode.JandexVlsiMultiModuleProjectDevModeTest.main - History - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes  30 seconds.
	at app//org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at app//io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:164)
	at app//io.quarkus.gradle.devmode.QuarkusDevGradleTestBase.getHttpResponse(QuarkusDevGradleTestBase.java:164)

✖ io.quarkus.gradle.devmode.MavenExclusionInExtensionDependencyDevModeTest.main - History - More details - Source on GitHub

java.lang.AssertionError: 
Expecting actual:
  "BROKEN: quarkusDev mode has terminated"
to contain:
  "Hello" 
	at app//io.quarkus.gradle.devmode.MavenExclusionInExtensionDependencyDevModeTest.testDevMode(MavenExclusionInExtensionDependencyDevModeTest.java:25)
	at app//io.quarkus.gradle.devmode.QuarkusDevGradleTestBase.main(QuarkusDevGradleTestBase.java:60)
	at java.base@17.0.13/java.lang.reflect.Method.invoke(Method.java:569)

✖ io.quarkus.gradle.devmode.MultiCompositeBuildExtensionsDevModeTest.main - History - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 5 minutes.
	at app//org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at app//io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:97)
	at app//io.quarkus.gradle.devmode.QuarkusDevGradleTestBase.getHttpResponse(QuarkusDevGradleTestBase.java:156)

✖ io.quarkus.gradle.devmode.QuarkusDevDependencyDevModeTest.main - History - More details - Source on GitHub

org.awaitility.core.ConditionTimeoutException: Condition with Lambda expression in io.quarkus.test.devmode.util.DevModeClient was not fulfilled within 1 minutes  30 seconds.
	at app//org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:78)
	at app//org.awaitility.core.CallableCondition.await(CallableCondition.java:26)
	at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:1006)
	at app//org.awaitility.core.ConditionFactory.until(ConditionFactory.java:975)
	at app//io.quarkus.test.devmode.util.DevModeClient.getHttpResponse(DevModeClient.java:164)
	at app//io.quarkus.gradle.devmode.QuarkusDevGradleTestBase.getHttpResponse(QuarkusDevGradleTestBase.java:164)

phillip-kruger · 2025-01-07T10:15:08Z

@phillip-kruger you keep loosing my changes when you rebase. There are more failures than before. I'll rebase and force push. However, the Gradle failures will be challenging to fix. They are not related to dev mode-only dependencies but conditional dependencies in general. See my previous comment.

Ai sorry, I keep on forgetting you also made changes. I'll leave this PR to you to get green :)

michalvavrik · 2025-01-14T21:22:36Z

hey @phillip-kruger , I think you need to update OIDC-related changes as we added new classes and changed some existing classes related to this PR. Thanks

aloubyansky · 2025-01-15T06:27:47Z

This PR is blocked by yet to be fixed bugs in our Gradle plug-in impl.

phillip-kruger requested review from cescoffier and aloubyansky December 11, 2024 06:11

phillip-kruger force-pushed the dev-only-deps branch from 6300f6b to 8fd64dc Compare December 11, 2024 06:13

This comment has been minimized.

Sign in to view

phillip-kruger added 21 commits January 7, 2025 08:39

Introduce Dev only module for Vertx HTTP extension

cbe5201

Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>

Introduce Dev only module for Websocket next extension

3319da8

Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>

Introduce Dev only module for Reactive Messaging extension

446c822

Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>

Introduce Dev only module for RabbitMQ Messaging extension

9ea6ff9

Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>

Introduce Dev only module for Fault tolerance extension

a1a629b

Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>

Introduce Dev only module for Scheduler extension

0c62766

Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>

Introduce Dev only module for Rest extension

1b36292

Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>

Introduce Dev only module for oidc extension

a00b5bf

Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>

Introduce Dev only module for Liquibase streams extension

69eb9e4

Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>

Introduce Dev only module for Kafka streams extension

707fe8d

Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>

Introduce Dev only module for Kafka client extension

bebef5f

Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>

Introduce Dev only module for Infinispan client extension

d4a1531

Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>

Introduce Dev only module for Hibernate Search Standalone Elasticsear…

646febe

…ch extension Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>

Introduce Dev only module for Hibernate Search ORM Elasticsearch exte…

4316386

…nsion Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>

Introduce Dev only module for Hibernate ORM extension

723520e

Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>

Introduce Dev only module for GRPC extension

b9771e7

Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>

Introduce Dev only module for Flyway extension

680e4d7

Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>

Introduce Dev only module for Datasource extension

da42abd

Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>

Introduce Dev only module for Container image extension

d47216d

Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>

Introduce Dev only module for Cache extension

e55990f

Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>

Introduce Dev only module for Arc extension

6406988

Signed-off-by: Phillip Kruger <phillip.kruger@gmail.com>

aloubyansky force-pushed the dev-only-deps branch from 038b2c9 to 6406988 Compare January 7, 2025 07:42

michalvavrik mentioned this pull request Jan 15, 2025

OIDC: reuse shared Vert.x instance in DEV and test mode whenever it is possible #45621

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce Dev only module for relevant extensions #45053

Introduce Dev only module for relevant extensions #45053

phillip-kruger commented Dec 11, 2024 •

edited

Loading

quarkus-bot bot commented Dec 11, 2024

github-actions bot commented Dec 11, 2024 •

edited

Loading

This comment has been minimized.

aloubyansky commented Dec 11, 2024

This comment has been minimized.

aloubyansky commented Dec 11, 2024

aloubyansky commented Dec 11, 2024

aloubyansky commented Dec 11, 2024

phillip-kruger commented Dec 11, 2024

phillip-kruger commented Jan 6, 2025

aloubyansky commented Jan 7, 2025

quarkus-bot bot commented Jan 7, 2025

quarkus-bot bot commented Jan 7, 2025 •

edited by github-actions bot

Loading

phillip-kruger commented Jan 7, 2025

michalvavrik commented Jan 14, 2025

aloubyansky commented Jan 15, 2025

Introduce Dev only module for relevant extensions #45053

Are you sure you want to change the base?

Introduce Dev only module for relevant extensions #45053

Conversation

phillip-kruger commented Dec 11, 2024 • edited Loading

quarkus-bot bot commented Dec 11, 2024

github-actions bot commented Dec 11, 2024 • edited Loading

This comment has been minimized.

aloubyansky commented Dec 11, 2024

This comment has been minimized.

aloubyansky commented Dec 11, 2024

aloubyansky commented Dec 11, 2024

aloubyansky commented Dec 11, 2024

phillip-kruger commented Dec 11, 2024

phillip-kruger commented Jan 6, 2025

aloubyansky commented Jan 7, 2025

quarkus-bot bot commented Jan 7, 2025

Status for workflow Quarkus Documentation CI

quarkus-bot bot commented Jan 7, 2025 • edited by github-actions bot Loading

Status for workflow Quarkus CI

Failing Jobs

Failures

⚙️ Maven Tests - JDK 17 Windows #

📦 integration-tests/maven

⚙️ Gradle Tests - JDK 17 #

📦 integration-tests/gradle

⚙️ Gradle Tests - JDK 17 Windows #

📦 integration-tests/gradle

phillip-kruger commented Jan 7, 2025

michalvavrik commented Jan 14, 2025

aloubyansky commented Jan 15, 2025

phillip-kruger commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

Status for workflow `Quarkus Documentation CI`

quarkus-bot bot commented Jan 7, 2025 •

edited by github-actions bot

Loading

Status for workflow `Quarkus CI`