[27.x backport] pkg/ioutils: deprecate NopWriter, NopWriteClose #49255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not used, and users can use io.Discard instead. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 7fa3c55) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
It was only used internally, and has no external consumers; deprecate it to be removed in the next release. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 3faa170) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
added
status/2-code-review
impact/changelog
impact/deprecation
area/go-sdk
vvoland
approved these changes
Jan 10, 2025
|
Failure is unrelated; known flaky; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/pkg#32989- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)