Add support for Linux ARM64 and macOS ARM64 (Silicon) targets. #2449

charleskorn · 2021-09-01T03:38:38Z

Currently blocked until a new version of kotlinx.coroutines is published with these targets (see Kotlin/kotlinx.coroutines#2904).

See #1743 (comment).

JavierSegoviaCordoba · 2021-09-01T09:21:30Z

Can you add the new Apple simulator targets too (ios tvos and watchos)?

charleskorn · 2021-09-01T23:28:01Z

Can you add the new Apple simulator targets too (ios tvos and watchos)?

Done.

charleskorn · 2021-09-02T02:31:09Z

Looks like #2450 broke some tests - could you take a look @sksamuel?

JavierSegoviaCordoba · 2021-09-02T13:59:58Z

Coroutines 1.5.2 and mt are available.

sksamuel · 2021-09-02T14:08:16Z

I hope 1.5.2 fixes my issue with Result cast exceptions :)

sksamuel · 2021-09-02T14:08:23Z

Looks like #2450 broke some tests - could you take a look @sksamuel?

Yep

Currently blocked until a new version of kotlinx.coroutines is published with these targets (Kotlin/kotlinx.coroutines#2904).

This adds support for the new Kotlin/Native targets added in Kotlin 1.5.30.

kotlinx-coroutines only supports X64.

charleskorn · 2021-09-03T05:17:53Z

This is ready for review @sksamuel.

sksamuel · 2021-09-03T13:35:09Z

Awesome 👍🏼

sksamuel · 2021-09-03T20:35:46Z

Don't know if this error means anything to you @charleskorn https://github.com/kotest/kotest/runs/3507598103?check_suite_focus=true

JavierSegoviaCordoba · 2021-09-03T20:41:33Z

Not sure if kotlin.native.enableDependencyPropagation=false in gradle.properties can fix that

JavierSegoviaCordoba · 2021-09-03T20:44:51Z

@sksamuel linuxArm64 isn't in kotlin coroutines:

        addTarget(presets.linuxX64)
        addTarget(presets.iosArm64)
        addTarget(presets.iosArm32)
        addTarget(presets.iosX64)
        addTarget(presets.macosX64)
        addTarget(presets.mingwX64)
        addTarget(presets.tvosArm64)
        addTarget(presets.tvosX64)
        addTarget(presets.watchosArm32)
        addTarget(presets.watchosArm64)
        addTarget(presets.watchosX86)
        addTarget(presets.watchosX64)
        addTarget(presets.iosSimulatorArm64)
        addTarget(presets.watchosSimulatorArm64)
        addTarget(presets.tvosSimulatorArm64)
        addTarget(presets.macosArm64)

sksamuel · 2021-09-03T20:48:48Z

The PR passed. I guess the PR workflow wasn't updated the same as the master workflow.

JavierSegoviaCordoba · 2021-09-03T21:12:16Z

we should ask in coroutines for this target, but it is strange it doesn't exist yet

JavierSegoviaCordoba · 2021-09-03T21:38:45Z

Kotlin/kotlinx.coroutines#855

charleskorn · 2021-09-04T05:19:50Z

Don't know if this error means anything to you @charleskorn https://github.com/kotest/kotest/runs/3507598103?check_suite_focus=true

Yep, that would be because kotlinx.coroutines doesn't support linuxArm64.

The PR passed. I guess the PR workflow wasn't updated the same as the master workflow.

The Linux PR workflow runs check, which should run everything that can be run on Linux (including building Linux ARM64 targets but not testing them), not sure why it didn't pick this up.

we should ask in coroutines for this target, but it is strange it doesn't exist yet

Sounds great, thanks for doing that.

In the meantime, do you want me to remove the linuxArm64 targets?

sksamuel · 2021-09-04T06:15:29Z

I think we should remove them for now yeah.

…

On Sat, 4 Sept 2021 at 00:20, Charles Korn ***@***.***> wrote: Don't know if this error means anything to you @charleskorn <https://github.com/charleskorn> https://github.com/kotest/kotest/runs/3507598103?check_suite_focus=true Yep, that would be because kotlinx.coroutines doesn't support linuxArm64. The PR passed. I guess the PR workflow wasn't updated the same as the master workflow. The Linux PR workflow runs check <https://github.com/kotest/kotest/pull/2449/files#diff-db41ffe2c658df28e2cc8e19c303f1b0942d56b6fb1b0fedc2dc3b916e005b00R28>, which should run everything that can be run on Linux (including building Linux ARM64 targets but not testing them), not sure why it didn't pick this up. we should ask in coroutines for this target, but it is strange it doesn't exist yet Sounds great, thanks for doing that. In the meantime, do you want me to remove the linuxArm64 targets? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2449 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFVSGVNJ5543CQ3ABRVFR3UAGUABANCNFSM5DFP4CNQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

See kotest#2449 (comment).

charleskorn · 2021-09-04T10:57:51Z

I've opened #2460 to remove the Linux ARM64 target.

JavierSegoviaCordoba · 2021-09-04T11:10:59Z

I created it too, but I forgot to modify the workflows, I will close it

See #2449 (comment).

charleskorn mentioned this pull request Sep 1, 2021

Kotlin/Native support #1743

Closed

ychescale9 mentioned this pull request Sep 2, 2021

Add apple silicon targets #2455

Closed

charleskorn force-pushed the more-native-targets branch from a468975 to e289ed1 Compare September 3, 2021 02:48

charleskorn added 5 commits September 3, 2021 13:31

Add support for Linux ARM64 and macOS ARM64 (Silicon) targets.

90f3a31

Currently blocked until a new version of kotlinx.coroutines is published with these targets (Kotlin/kotlinx.coroutines#2904).

Add ARM64 simulator targets.

93cd14b

Don't try to run testing task that doesn't exist.

496bd2b

Test all available targets on Windows or macOS as part of the PR build.

e8b94c6

Use kotlinx-coroutines 1.5.2.

36cd2df

This adds support for the new Kotlin/Native targets added in Kotlin 1.5.30.

charleskorn force-pushed the more-native-targets branch from 2310c96 to 36cd2df Compare September 3, 2021 03:49

Remove mingwX86 target.

6620c1e

kotlinx-coroutines only supports X64.

charleskorn marked this pull request as ready for review September 3, 2021 05:17

sksamuel merged commit d183857 into kotest:master Sep 3, 2021

sksamuel mentioned this pull request Sep 3, 2021

Roadmap 5.0 #2226

Closed

71 tasks

charleskorn added a commit to charleskorn/kotest that referenced this pull request Sep 4, 2021

Remove Linux ARM64 target.

d760b8c

See kotest#2449 (comment).

charleskorn mentioned this pull request Sep 4, 2021

Remove Linux ARM64 target. #2460

Merged

sksamuel pushed a commit that referenced this pull request Sep 4, 2021

Remove Linux ARM64 target. (#2460)

5bde511

See #2449 (comment).

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for Linux ARM64 and macOS ARM64 (Silicon) targets. #2449

Add support for Linux ARM64 and macOS ARM64 (Silicon) targets. #2449

charleskorn commented Sep 1, 2021

JavierSegoviaCordoba commented Sep 1, 2021 •

edited

Loading

charleskorn commented Sep 1, 2021

charleskorn commented Sep 2, 2021

JavierSegoviaCordoba commented Sep 2, 2021

sksamuel commented Sep 2, 2021

sksamuel commented Sep 2, 2021

charleskorn commented Sep 3, 2021

sksamuel commented Sep 3, 2021

sksamuel commented Sep 3, 2021

JavierSegoviaCordoba commented Sep 3, 2021

JavierSegoviaCordoba commented Sep 3, 2021

sksamuel commented Sep 3, 2021

JavierSegoviaCordoba commented Sep 3, 2021

JavierSegoviaCordoba commented Sep 3, 2021

charleskorn commented Sep 4, 2021

sksamuel commented Sep 4, 2021 via email

charleskorn commented Sep 4, 2021

JavierSegoviaCordoba commented Sep 4, 2021

Add support for Linux ARM64 and macOS ARM64 (Silicon) targets. #2449

Add support for Linux ARM64 and macOS ARM64 (Silicon) targets. #2449

Conversation

charleskorn commented Sep 1, 2021

JavierSegoviaCordoba commented Sep 1, 2021 • edited Loading

charleskorn commented Sep 1, 2021

charleskorn commented Sep 2, 2021

JavierSegoviaCordoba commented Sep 2, 2021

sksamuel commented Sep 2, 2021

sksamuel commented Sep 2, 2021

charleskorn commented Sep 3, 2021

sksamuel commented Sep 3, 2021

sksamuel commented Sep 3, 2021

JavierSegoviaCordoba commented Sep 3, 2021

JavierSegoviaCordoba commented Sep 3, 2021

sksamuel commented Sep 3, 2021

JavierSegoviaCordoba commented Sep 3, 2021

JavierSegoviaCordoba commented Sep 3, 2021

charleskorn commented Sep 4, 2021

sksamuel commented Sep 4, 2021 via email

charleskorn commented Sep 4, 2021

JavierSegoviaCordoba commented Sep 4, 2021

JavierSegoviaCordoba commented Sep 1, 2021 •

edited

Loading