Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kotest 5.4.x-SNAPSHOT does not seem to work together with Spring 2.7.1 #3084

Closed
mor4thii opened this issue Jul 4, 2022 · 6 comments
Closed
Labels
bug 🐛 Issues that report a problem or error in the code.

Comments

@mor4thii
Copy link

mor4thii commented Jul 4, 2022

Hi,

I have an issue w/ kotest:5.4.0-1038-SNAPSHOT (and all other SNAPSHOTs of 5.4.0, and 5.3.2, and 5.3.0)

I tried to update to Spring 2.7.1 today and I got the following error from maven:
Unresolved dependency: 'org.jetbrains.kotlinx:kotlinx-coroutines-bom:jar:1.6.3'

From what I was able to test, it works with Spring 2.7.0 and all kotest versions mentioned above. Also, it appears with both Kotlin v1.6.21 and v1.7.0. Spring 2.7.1 changed the coroutines version here: spring-projects/spring-boot@4f6bc3c
From what I can see, kotest and spring boot now depend on the same version of kotlin coroutines

I created a small example repository for observing this behaviour: https://github.com/mor4thii/spring-kotest-demo
It is based on a simple app generated by Spring initializr.

Now, I am not too familiar with issue reports (this is my first issue on github!), and in this case, I am not sure whether this issue applies to kotest or Spring Boot. Please feel free to point me in the right direction :)

@sksamuel
Copy link
Member

sksamuel commented Jul 4, 2022

I think probably the same thing as this? https://kotlinlang.slack.com/archives/CT0G9SD7Z/p1656524779419449

@mor4thii
Copy link
Author

mor4thii commented Jul 6, 2022

Yeah, seems to be the same issue, but with quarkus.

@Kantis
Copy link
Member

Kantis commented Jul 6, 2022

Jetbrains seem to be working on a fix.
Likely only affecting Maven builds.
Kotlin/kotlinx.coroutines#3334

@Kantis Kantis added bug 🐛 Issues that report a problem or error in the code. external labels Jul 6, 2022
@mor4thii
Copy link
Author

mor4thii commented Jul 6, 2022

TYVM for linking this here.

@mor4thii
Copy link
Author

I just wanted to report that with the 2.7.2 release of Spring (https://github.com/spring-projects/spring-boot/releases/tag/v2.7.2), the issue has been resolved. They use coroutines in v1.6.4, just as kotest does :)

@sksamuel
Copy link
Member

Closing as fixed in latest spring release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Issues that report a problem or error in the code.
Projects
None yet
Development

No branches or pull requests

3 participants