Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create async sql tutorial001 for python3.10 #5568

Closed
wants to merge 4 commits into from

Conversation

SXHRYU
Copy link

@SXHRYU SXHRYU commented Nov 1, 2022

replaced typing.List with list

replaced `typing.List` with `list`
@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (cf73051) to head (1c23a85).
Report is 1325 commits behind head on master.

❗ Current head 1c23a85 differs from pull request most recent head 29695a7. Consider uploading reports for the commit 29695a7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #5568   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          540       540           
  Lines        13969     13946   -23     
=========================================
- Hits         13969     13946   -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2022

📝 Docs preview for commit 1c23a85 at: https://6360fe33ee1d991857649c11--fastapi.netlify.app

@github-actions
Copy link
Contributor

📝 Docs preview for commit aebdfd5 at: https://639cc85e3508160c310a9085--fastapi.netlify.app

@tiangolo tiangolo added the docs Documentation about how to use FastAPI label Oct 2, 2023
@alejsdev alejsdev added the p4 label Jan 13, 2024
@tiangolo
Copy link
Member

📝 Docs preview for commit 29695a7 at: https://0c071d84.fastapitiangolo.pages.dev

@rafalkrupinski
Copy link

import databases?

Is it possible to use standard sqlalchemy.ext.asyncio?

Copy link
Contributor

📝 Docs preview for commit 23246dd at: https://b1963e73.fastapitiangolo.pages.dev

@alejsdev
Copy link
Member

Hi @SXHRYU, thanks for your interest and patience, we already reviewed your PR but it seems this section (https://fastapi.tiangolo.com/how-to/async-sql-encode-databases/) is deprecated now, so I'll leave the final decision to @tiangolo. 🤔

@tiangolo
Copy link
Member

tiangolo commented Oct 9, 2024

Thanks for the interest! ☕

I wanted to re-write the SQL docs with SQLModel, I just finished that here: #12285

The new docs are here: https://fastapi.tiangolo.com/tutorial/sql-databases/

I also plan on adding support and docs for working with async code with SQLModel, and then I'll update the docs here.

Given that, I'll pass on this one, but thanks for the effort! 🍰

@tiangolo tiangolo closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation about how to use FastAPI p4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants