-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create async sql tutorial001 for python3.10 #5568
Conversation
replaced `typing.List` with `list`
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5568 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 540 540
Lines 13969 13946 -23
=========================================
- Hits 13969 13946 -23 ☔ View full report in Codecov by Sentry. |
📝 Docs preview for commit 1c23a85 at: https://6360fe33ee1d991857649c11--fastapi.netlify.app |
📝 Docs preview for commit aebdfd5 at: https://639cc85e3508160c310a9085--fastapi.netlify.app |
📝 Docs preview for commit 29695a7 at: https://0c071d84.fastapitiangolo.pages.dev |
Is it possible to use standard |
📝 Docs preview for commit 23246dd at: https://b1963e73.fastapitiangolo.pages.dev |
Hi @SXHRYU, thanks for your interest and patience, we already reviewed your PR but it seems this section (https://fastapi.tiangolo.com/how-to/async-sql-encode-databases/) is deprecated now, so I'll leave the final decision to @tiangolo. 🤔 |
Thanks for the interest! ☕ I wanted to re-write the SQL docs with SQLModel, I just finished that here: #12285 The new docs are here: https://fastapi.tiangolo.com/tutorial/sql-databases/ I also plan on adding support and docs for working with async code with SQLModel, and then I'll update the docs here. Given that, I'll pass on this one, but thanks for the effort! 🍰 |
replaced
typing.List
withlist