Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌐 Add Korean translation for docs/ko/docs/management.md #12548

Closed
wants to merge 1 commit into from
Closed

🌐 Add Korean translation for docs/ko/docs/management.md #12548

wants to merge 1 commit into from

Conversation

nahyunkeem
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the lang-all Translations label Oct 25, 2024
@sodaMelon
Copy link

idk why the new docs are not being created by github action

hi @tiangolo, could you check this problem again?
#12527 (you said it was fixed recently, but......... 🤔 )

sodaMelon
sodaMelon reviewed Oct 26, 2024
View reviewed changes
docs/ko/docs/management.md
## 외부 기여

질문에 대한 답변, PR 제출 등 외부 기여를 매우 환영하고 감사하게 생각합니다. 🙇‍♂️
[FastAPI를 유지하는 데 도움을 줄 수 있는](https://github.com/fastapi/fastapi/blob/master/docs/en/docs/help-fastapi.md#help-maintain-fastapi){.internal-link target=_blank}[] 방법은 여러 가지가 있습니다.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[FastAPI를 유지하는 데 도움을 줄 수 있는](https://github.com/fastapi/fastapi/blob/master/docs/en/docs/help-fastapi.md#help-maintain-fastapi){.internal-link target=_blank}[] 방법은 여러 가지가 있습니다.
[FastAPI를 유지하는 데 도움을 줄 수 있는](https://github.com/fastapi/fastapi/blob/master/docs/en/docs/help-fastapi.md#help-maintain-fastapi){.internal-link target=_blank} 방법은 여러 가지가 있습니다.

This is unnecessary.

sodaMelon
sodaMelon reviewed Oct 26, 2024
View reviewed changes
Copy link

@sodaMelon sodaMelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
For now, the documentation is not being generated. so we'll have to wait a bit longer.

@alejsdev alejsdev added awaiting-review lang-ko Korean translations labels Oct 26, 2024
@alejsdev
Copy link
Member

Hi @nahyunkeem 🤓
Thanks for your interest in contributing to the project! However, we're not translating this page (that's why the Build Docs is failing), you can see more information here: https://7fd003ac.fastapitiangolo.pages.dev/contributing/#dont-translate-these-pages
So, I'll close this one, but thanks for the effort! 🚀

@alejsdev alejsdev closed this Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sodaMelon sodaMelon sodaMelon left review comments

Assignees
No one assigned
Labels
awaiting-review lang-all Translations lang-ko Korean translations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nahyunkeem @sodaMelon @alejsdev