fix: segfault when moving WebContentsView between BrowserWindows #44599
+58
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkleinsc
added
semver/patch
VerteDinde
approved these changes
Nov 11, 2024
|
Release Notes Persisted
|
This was referenced Nov 11, 2024
|
I have automatically backported this PR to "34-x-y", please check out #44612 |
trop
bot
removed
the
target/34-x-y
|
I have automatically backported this PR to "33-x-y", please check out #44613 |
|
I have automatically backported this PR to "31-x-y", please check out #44614 |
|
I have automatically backported this PR to "32-x-y", please check out #44615 |
trop
bot
added
in-flight/33-x-y
in-flight/31-x-y
in-flight/32-x-y
and removed
target/33-x-y
trop
bot
added
merged/34-x-y
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The root of this issue is that View was not properly accounting for children that had been removed by being moved over to another View. This PR fixes that issue by using
OnChildViewRemovedfromviews::ViewObserverto handle this use case.This PR also adds a test case to verify this fix.
Here is a run with that test case before the fix has been applied:
https://github.com/electron/electron/actions/runs/11748536232/job/32734670103?pr=44599
Checklist
npm testpassesRelease Notes
Notes: Fixed segfault when moving WebContentsView between BrowserWindows.