feat(Client): add request soundboard sounds #10608
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10608 +/- ##
==========================================
- Coverage 38.18% 37.36% -0.83%
==========================================
Files 239 240 +1
Lines 15563 15351 -212
Branches 1376 1384 +8
==========================================
- Hits 5943 5736 -207
+ Misses 9605 9600 -5
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sdanialraza
force-pushed
the
feat/add-request-soundboard-sounds
branch
3 times, most recently
from
af803db to
9752195
Compare
sdanialraza
requested review from
vladfrangu,
iCrawl,
didinele,
Jiralite and
SpaceEEC
sdanialraza
force-pushed
the
feat/add-request-soundboard-sounds
branch
from
9752195 to
c65644c
Compare
| * // Map { 20 => [ { name: 'Alice', age: 20 }, { name: 'Bob', age: 20 } ], 30 => [ { name: 'Charlie', age: 30 } ] } | ||
| * ``` | ||
| */ | ||
| export function groupBy<Key, Value>( |
There was a problem hiding this comment.
is there... a reason for this? MDN says it's in node 21+
There was a problem hiding this comment.
Our minimum required Node.js version is 20. Unless we do 22, this polyfill is needed.
There was a problem hiding this comment.
right. well... if we're doing v15 we.. could?
Co-authored-by: Almeida <github@almeidx.dev>
Please describe the changes this PR makes and why it should be merged:
Adds iterator and non-iterator variants for requesting soundboard sounds for core
Status and versioning classification: