Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @tbg)

pkg/sql/tests/sniff_args_test.go line 25 at r1 (raw file):

// This is a helper for benchmarks that want to react to flags from their
// environment.
func sniffArgs(inArgs []string, names []string, out []*string) error {

[nit] Is there any advantage to passing all args at once, vs multiple calls like memProfile := sniffArg(inArgs, "test.memprofile") which look much cleaner?

Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @tbg)

pkg/sql/tests/sniff_args_test.go line 25 at r1 (raw file):

// This is a helper for benchmarks that want to react to flags from their
// environment.
func sniffArgs(inArgs []string, names []string, out []*string) error {

[nit] This could live in a sniff_args.go, we have other things like that.