Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ec2_vpc_route_table* modules #2159

Merged
merged 4 commits into from
Jul 11, 2024
Merged

Refactor ec2_vpc_route_table* modules #2159

merged 4 commits into from
Jul 11, 2024

Conversation

abikouo
Copy link
Contributor

@abikouo abikouo commented Jul 1, 2024 •
edited
Loading

SUMMARY

Refactor ec2_vpc_route_table modules

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • ec2_vpc_route_table
  • ec2_vpc_route_table_info

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/1bd68cbf7ca04ef18ce8df77ba6ac750

✔️ ansible-galaxy-importer SUCCESS in 3m 24s
✔️ build-ansible-collection SUCCESS in 12m 57s
✔️ ansible-test-splitter SUCCESS in 5m 03s
✔️ integration-amazon.aws-1 SUCCESS in 18m 06s
Skipped 43 jobs

@GomathiselviS
Copy link
Collaborator

Can you please add type annotations to all the functions to maintain consistency?

@abikouo
Copy link
Contributor Author

abikouo commented Jul 5, 2024

Can you please add type annotations to all the functions to maintain consistency?

@GomathiselviS Adding type annotations to all the functions is a huge effort and is not in this update's scope.
I have done it on modified/new functions, for the other functions this will be addressed in another task.

hakbailey
hakbailey reviewed Jul 5, 2024
View reviewed changes
plugins/modules/ec2_vpc_route_table.py Outdated Show resolved Hide resolved
plugins/modules/ec2_vpc_route_table.py Outdated Show resolved Hide resolved
@abikouo abikouo requested a review from hakbailey July 8, 2024 10:25
@abikouo abikouo force-pushed the refactor_ec2_vpc_route_table_2401071331 branch from 67a6cfa to 6da4200 Compare July 8, 2024 10:26
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/80e840fe6bd04df89056caf3d606d248

✔️ ansible-galaxy-importer SUCCESS in 4m 14s
✔️ build-ansible-collection SUCCESS in 12m 33s
✔️ ansible-test-splitter SUCCESS in 4m 56s
✔️ integration-amazon.aws-1 SUCCESS in 19m 22s
Skipped 43 jobs

alinabuzachis
alinabuzachis approved these changes Jul 8, 2024
View reviewed changes
plugins/modules/ec2_vpc_route_table.py Outdated Show resolved Hide resolved
plugins/modules/ec2_vpc_route_table.py Outdated Show resolved Hide resolved
@abikouo abikouo force-pushed the refactor_ec2_vpc_route_table_2401071331 branch from 6da4200 to 74c99e8 Compare July 8, 2024 15:10
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.
https://ansible.softwarefactory-project.io/zuul/buildset/60e5bb9e8d764efcb8699a9d248bea3f

✔️ ansible-galaxy-importer SUCCESS in 5m 07s
✔️ build-ansible-collection SUCCESS in 12m 39s
✔️ ansible-test-splitter SUCCESS in 5m 05s
✔️ integration-amazon.aws-1 SUCCESS in 17m 36s
Skipped 43 jobs

@abikouo abikouo force-pushed the refactor_ec2_vpc_route_table_2401071331 branch from 74c99e8 to ab0646f Compare July 11, 2024 08:56
@abikouo abikouo added the mergeit Merge the PR (SoftwareFactory) label Jul 11, 2024
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).
https://ansible.softwarefactory-project.io/zuul/buildset/66ff7f1656f246cf80a924f4e6f423e9

✔️ ansible-galaxy-importer SUCCESS in 4m 43s
✔️ build-ansible-collection SUCCESS in 13m 24s
✔️ ansible-test-splitter SUCCESS in 5m 19s
✔️ integration-amazon.aws-1 SUCCESS in 17m 35s
Skipped 43 jobs

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit 5a5cc60 into ansible-collections:main Jul 11, 2024
36 checks passed
abikouo added a commit to abikouo/amazon.aws that referenced this pull request Oct 15, 2024
@abikouo
Prepare modules ec2_vpc_nacl and ec2_vpc_nacl_info for promotion (ans…
bd9ffb7 
…ible-collections#2159)

SUMMARY

Use shared code from amazon.aws.plugins.module_utils.ec2
Refactor module ec2_vpc_nacl and ec2_vpc_nacl_info

ISSUE TYPE

Feature Pull Request

Reviewed-by: Alina Buzachis
Reviewed-by: Bikouo Aubin
Reviewed-by: GomathiselviS

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@86d268f
abikouo added a commit to abikouo/amazon.aws that referenced this pull request Oct 16, 2024
@abikouo
Prepare modules ec2_vpc_nacl and ec2_vpc_nacl_info for promotion (ans…
fd0f652 
…ible-collections#2159)

SUMMARY

Use shared code from amazon.aws.plugins.module_utils.ec2
Refactor module ec2_vpc_nacl and ec2_vpc_nacl_info

ISSUE TYPE

Feature Pull Request

Reviewed-by: Alina Buzachis
Reviewed-by: Bikouo Aubin
Reviewed-by: GomathiselviS

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@86d268f
abikouo added a commit to abikouo/amazon.aws that referenced this pull request Oct 17, 2024
@abikouo
Prepare modules ec2_vpc_nacl and ec2_vpc_nacl_info for promotion (ans…
c7930d5 
…ible-collections#2159)

SUMMARY

Use shared code from amazon.aws.plugins.module_utils.ec2
Refactor module ec2_vpc_nacl and ec2_vpc_nacl_info

ISSUE TYPE

Feature Pull Request

Reviewed-by: Alina Buzachis
Reviewed-by: Bikouo Aubin
Reviewed-by: GomathiselviS

This commit was initially merged in https://github.com/ansible-collections/community.aws
See: ansible-collections/community.aws@86d268f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alinabuzachis alinabuzachis alinabuzachis approved these changes

@hakbailey hakbailey Awaiting requested review from hakbailey

Assignees
No one assigned
Labels
mergeit Merge the PR (SoftwareFactory)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abikouo @GomathiselviS @hakbailey @alinabuzachis