fix(core): prevent stash listener conflicts #59635
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturovt
force-pushed
the
fix/core-stash-conflicts
branch
5 times, most recently
from
93414f0 to
20b19ab
Compare
JoostK
reviewed
Jan 20, 2025
Comment on lines
237
to
238
| const stashEventListener = stashEventListeners.get(appId)!; | ||
| stashEventListener(native, eventName, listenerFn); |
There was a problem hiding this comment.
The non null assertion deviates from a prior safety net where an empty closure would be used, so the following seems safer and less of a change:
Suggested change
| const stashEventListener = stashEventListeners.get(appId)!; | |
| stashEventListener(native, eventName, listenerFn); | |
| const stashEventListener = stashEventListeners.get(appId); | |
| stashEventListener?.(native, eventName, listenerFn); |
There was a problem hiding this comment.
Updated to optional chaining.
arturovt
force-pushed
the
fix/core-stash-conflicts
branch
from
20b19ab to
7c91668
Compare
The stash event listener is a global function that might be unsafely overridden if multiple microfrontend applications exist on the page. In this commit, we create a map of `APP_ID` to stash event listener functions. This map prevents conflicts because multiple applications might be bootstrapped simultaneously on the client (one rendered on the server and one rendering only on the client). I.e., the code that might be used is: ```ts // Given that `app-root` is rendered on the server bootstrapApplication(AppComponent, appConfig); bootstrapApplication(BlogRootComponent, appBlogConfig); ``` Two bootstrapped applications would conflict and override each other's code.
arturovt
force-pushed
the
fix/core-stash-conflicts
branch
from
7c91668 to
f29a5a8
Compare
thePunderWoman
requested changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stash event listener is a global function that might be unsafely overridden if multiple microfrontend applications exist on the page.
In this commit, we create a map of
APP_IDto stash event listener functions. This map prevents conflicts because multiple applications might be bootstrapped simultaneously on the client (one rendered on the server and one rendering only on the client).I.e., the code that might be used is:
Two bootstrapped applications would conflict and override each other's code.