Make EventLoopImplBase properly synchronized on Kotlin/Native #3550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwwdfsad
requested review from
dkhalanskyjb
and removed request for
dkhalanskyjb
There was a problem hiding this comment.
In the meantime, this class of errors isn't present anywhere else:
$ git grep '@Synchronized'
kotlinx-coroutines-core/jvm/src/DefaultExecutor.kt: @Synchronized
kotlinx-coroutines-core/jvm/src/DefaultExecutor.kt: @Synchronized
kotlinx-coroutines-core/jvm/src/DefaultExecutor.kt: @Synchronized
kotlinx-coroutines-core/jvm/src/DefaultExecutor.kt: @Synchronized // used _only_ for tests
kotlinx-coroutines-core/jvm/src/DefaultExecutor.kt: @Synchronized
kotlinx-coroutines-core/jvm/src/debug/internal/ConcurrentWeakMap.kt: @Synchronized
kotlinx-coroutines-core/jvm/src/scheduling/Dispatcher.kt: @Synchronized
kotlinx-coroutines-core/jvm/src/scheduling/Dispatcher.kt: @Synchronized
kotlinx-coroutines-core/jvm/test/VirtualTimeSource.kt: @Synchronized
kotlinx-coroutines-core/jvm/test/VirtualTimeSource.kt: @Synchronized
kotlinx-coroutines-core/jvm/test/VirtualTimeSource.kt: @Synchronized
kotlinx-coroutines-core/jvm/test/VirtualTimeSource.kt: @Synchronized
kotlinx-coroutines-core/jvm/test/VirtualTimeSource.kt: @Synchronized
kotlinx-coroutines-core/jvm/test/VirtualTimeSource.kt: @Synchronized
reactive/kotlinx-coroutines-reactive/src/Await.kt: @Synchronized
|
We actually DM'ed and decided to deprecate it the moment the issue was found: https://youtrack.jetbrains.com/issue/KT-55292/DM-2022-12-08-Volatile-Synchronized-annotations-in-multiplatform |
dkhalanskyjb
approved these changes
Dec 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3547