Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parametrized Flow#filterIsInstance extension #3464

Merged
merged 3 commits into from
Sep 28, 2022
Merged

Add parametrized Flow#filterIsInstance extension #3464

merged 3 commits into from
Sep 28, 2022

Conversation

IgnatBeresnev
Copy link
Member

Fixes #3240

@IgnatBeresnev IgnatBeresnev changed the title Add parametrized filterIsInstance extension Add parametrized Flow#filterIsInstance extension Sep 26, 2022
qwwdfsad
qwwdfsad reviewed Sep 26, 2022
View reviewed changes
Copy link
Collaborator

@qwwdfsad qwwdfsad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like you forgot to run apiDump

@IgnatBeresnev
Copy link
Member Author

It seems like you forgot to run apiDump

Yeah, initially I did, so I ran it and committed changes with the second commit. Should be good now

@IgnatBeresnev
Copy link
Member Author

Execution failed for task ':kotlinNpmInstall'. java.lang.IllegalStateException: Process 'Resolving NPM dependencies using yarn' returns 1

Doesn't look like it should be caused by PR changes, hopefully it's temporary, I'll restart it tomorrow

qwwdfsad
qwwdfsad approved these changes Sep 27, 2022
View reviewed changes
Copy link
Collaborator

@qwwdfsad qwwdfsad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👍

kotlinx-coroutines-core/common/src/flow/operators/Transform.kt Show resolved Hide resolved
@IgnatBeresnev
Copy link
Member Author

@dkhalanskyjb, I assume you've had a look and I can merge it? Don't wanna come off as rude and ignore your review :)

@dkhalanskyjb dkhalanskyjb merged commit 85a2601 into develop Sep 28, 2022
@dkhalanskyjb dkhalanskyjb deleted the 3240_parametrized-filter-is-instance branch September 28, 2022 15:06
@dkhalanskyjb
Copy link
Collaborator

Ah, yes, everything's good.

@IgnatBeresnev IgnatBeresnev mentioned this pull request Sep 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwwdfsad qwwdfsad qwwdfsad approved these changes

@dkhalanskyjb dkhalanskyjb Awaiting requested review from dkhalanskyjb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@IgnatBeresnev @dkhalanskyjb @qwwdfsad