Introduce Dispatchers.shutdown #2915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkhalanskyjb
requested changes
Sep 6, 2021
There was a problem hiding this comment.
The comments I made in #2903 (review) are somewhat applicable here: I think that we need to establish and document some specific behavior for cases where there are some pending jobs at the moment of shutting down the dispatchers.
As is, I managed to get a highly confusing and uninformative error with this code:
val j = GlobalScope.launch {
delay(1000)
println("won't be reached")
}
GlobalScope.launch {
Dispatchers.shutdown()
j.join()
}The error:
Exception in thread Thread[DefaultDispatcher-worker-1 @coroutine#1,5,main]: java.lang.AssertionError
java.lang.AssertionError
at kotlinx.coroutines.EventLoopImplPlatform.reschedule(EventLoop.kt:17)
at kotlinx.coroutines.EventLoopImplBase.schedule(EventLoop.common.kt:362)
at kotlinx.coroutines.EventLoopImplBase.scheduleResumeAfterDelay(EventLoop.common.kt:235)
at kotlinx.coroutines.DelayKt.delay(Delay.kt:121)
at kotlinx.coroutines.RunBlockingTest$dispatcherShutdownTest$j$1.invokeSuspend(RunBlockingTest.kt:15)
at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:571)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:750)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:678)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:665)
|
I've improved the exception message and documentation. The API is marked as delicate and has a pretty narrow use case, so I'm not sure it's worth (both in terms of contract and maintainability) giving more guarantees than now. |
dkhalanskyjb
requested changes
Sep 6, 2021
Co-authored-by: dkhalanskyjb <52952525+dkhalanskyjb@users.noreply.github.com>
dkhalanskyjb
approved these changes
Sep 9, 2021
# Conflicts: # kotlinx-coroutines-core/jvm/src/CoroutineContext.kt # kotlinx-coroutines-core/jvm/test/TestBase.kt
pablobaxter
pushed a commit
to pablobaxter/kotlinx.coroutines
that referenced
this pull request
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2558