Add type definitions for Enhance https://enhance.dev/ #71725
Conversation
|
@agawley Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through. This is a live comment that I will keep updated. 1 package in this PR
Code ReviewsThis PR adds a new definition, so it needs to be reviewed by a DT maintainer before it can be merged. You can test the changes of this PR in the Playground. Status
Once every item on this list is checked, I'll ask you for permission to merge and publish the changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 71725,
"author": "agawley",
"headCommitOid": "10894aa4e8d1717516ae8867f3fbaa50e88785ea",
"mergeBaseOid": "1d976b9454356ea4146621002c270b78b2c4d7cf",
"lastPushDate": "2025-01-22T17:33:05.000Z",
"lastActivityDate": "2025-01-22T17:33:05.000Z",
"hasMergeConflict": false,
"isFirstContribution": true,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Well-liked by everyone",
"pkgInfo": [
{
"name": "enhance__enhance",
"kind": "add",
"files": [
{
"path": "types/enhance__enhance/.eslintrc.json",
"kind": "package-meta",
"suspect": "edited"
},
{
"path": "types/enhance__enhance/.npmignore",
"kind": "package-meta-ok"
},
{
"path": "types/enhance__enhance/enhance__enhance-tests.ts",
"kind": "test"
},
{
"path": "types/enhance__enhance/index.d.ts",
"kind": "definition"
},
{
"path": "types/enhance__enhance/package.json",
"kind": "package-meta-ok"
},
{
"path": "types/enhance__enhance/tsconfig.json",
"kind": "package-meta-ok"
}
],
"owners": [],
"addedOwners": [
"agawley"
],
"deletedOwners": [],
"popularityLevel": "Well-liked by everyone"
}
],
"reviews": [],
"mainBotCommentID": 2607855655,
"ciResult": "pass"
} |
typescript-bot
added
New Definition
|
🔔 @agawley — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...) |
|
@agawley The CI build failed! Please review the logs for more information. Once you've pushed the fixes, the build will automatically re-run. Thanks! Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review. |
Please fill in this template.
pnpm test <package to test>.Select one of these and delete the others:
If adding a new definition:
.d.tsfiles generated via--declarationdts-gen --dt, not by basing it on an existing project.tsconfig.jsonshould havenoImplicitAny,noImplicitThis,strictNullChecks, andstrictFunctionTypesset totrue.These are basic types for the Enhance project. They are modelled after the types in @enhance/types but with some corrections. I'd like to put them on DefinitelyTyped for consistency and maintainability. I hope to add more types over time -particularly for their @enhance/custom-element package.