Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node: Add deferred tag for ts5.6 #70084

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from
Draft

node: Add deferred tag for ts5.6 #70084

wants to merge 12 commits into from
+6,504 −6,504

Conversation

sandersn
Copy link
Contributor

sandersn added 5 commits July 16, 2024 13:49
@sandersn
Done halfway through fs.d.ts
a9d45b1 
specifically, utimes
@sandersn
Add more @deferred
1595da1 
Done up to http.d.ts now.
@sandersn
Add tags to rest of files in toplevel
2e5cf21 
Still need to cover ts4.8, v16, v18
@sandersn
Start adding v16 and v18 tags too
2dbf579 
Largely based on v20 find/replace commands, since the files are largely
the same.

Done through events.d.ts.
@sandersn
Rest of v16/v18 deferred annotations
b814823 
Plus a few fixes to v20 files
@sandersn sandersn marked this pull request as ready for review July 17, 2024 22:39
@typescript-bot
Copy link
Contributor

typescript-bot commented Jul 17, 2024 •
edited
Loading

@sandersn Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • 🕐 A DT maintainer needs to approve changes that affect module config files

Once every item on this list is checked, I'll ask you for permission to merge and publish the changes.

Inactive

This PR has been inactive for 11 days — please try to get reviewers!

Diagnostic Information: What the bot saw about this PR 
{
  "type": "info",
  "now": "-",
  "pr_number": 70084,
  "author": "sandersn",
  "headCommitOid": "e6281f0017e08520a22b3864be579564ede18ede",
  "mergeBaseOid": "7524d7e61fd44fc26df5e2ec13dd1dea575f9cae",
  "lastPushDate": "2024-07-17T18:43:36.000Z",
  "lastActivityDate": "2024-07-18T17:03:03.000Z",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": true,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "node",
      "kind": "edit",
      "files": [
        {
          "path": "types/node/assert.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/async_hooks.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/child_process.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/cluster.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/crypto.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/dgram.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/diagnostics_channel.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/dns.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/dom-events.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/domain.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/events.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/fs.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/globals.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/http.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/http2.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/https.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/inspector.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/net.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/perf_hooks.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/process.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/readline.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/readline/promises.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/repl.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/scripts/generate-inspector/event-emitter.ts",
          "kind": "test"
        },
        {
          "path": "types/node/scripts/generate-inspector/generate-substitute-args.ts",
          "kind": "test"
        },
        {
          "path": "types/node/scripts/generate-inspector/inspector.d.ts.template",
          "kind": "package-meta",
          "suspect": "edited"
        },
        {
          "path": "types/node/stream.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/stream/promises.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/test.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/timers.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/tls.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/tty.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/util.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v16/assert.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v16/async_hooks.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v16/child_process.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v16/cluster.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v16/crypto.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v16/dgram.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v16/diagnostics_channel.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v16/dns.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v16/dom-events.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v16/domain.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v16/events.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v16/fs.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v16/globals.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v16/http.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v16/http2.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v16/https.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v16/inspector.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v16/net.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v16/perf_hooks.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v16/process.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v16/readline.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v16/repl.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v16/stream.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v16/stream/promises.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v16/test.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v16/timers.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v16/tls.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v16/tty.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v16/util.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v18/assert.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v18/async_hooks.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v18/child_process.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v18/cluster.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v18/crypto.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v18/dgram.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v18/diagnostics_channel.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v18/dns.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v18/dom-events.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v18/domain.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v18/events.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v18/fs.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v18/globals.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v18/http.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v18/http2.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v18/https.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v18/inspector.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v18/net.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v18/perf_hooks.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v18/process.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v18/readline.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v18/readline/promises.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v18/repl.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v18/stream.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v18/stream/promises.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v18/test.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v18/timers.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v18/tls.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v18/tty.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v18/util.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v8.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/vm.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/worker_threads.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/zlib.d.ts",
          "kind": "definition"
        }
      ],
      "owners": [
        "Microsoft",
        "jkomyno",
        "alvis",
        "r3nya",
        "btoueg",
        "smac89",
        "touffy",
        "DeividasBakanas",
        "eyqs",
        "Hannes-Magnusson-CK",
        "hoo29",
        "kjin",
        "ajafff",
        "islishude",
        "mwiktorczyk",
        "mohsen1",
        "galkin",
        "parambirs",
        "eps1lon",
        "ThomasdenH",
        "WilcoBakker",
        "wwwy3y3",
        "samuela",
        "kuehlein",
        "bhongy",
        "chyzwar",
        "trivikr",
        "yoursunny",
        "qwelias",
        "ExE-Boss",
        "peterblazejewicz",
        "addaleax",
        "victorperin",
        "ZYSzys",
        "NodeJS",
        "LinusU",
        "wafuwafu13",
        "mcollina",
        "Semigradsky"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "stale",
      "reviewer": "jakebailey",
      "date": "2024-07-18T16:59:12.000Z",
      "abbrOid": "2075be0"
    }
  ],
  "mainBotCommentID": 2234489705,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. Critical package Check Config Changes a module config files Huge Change labels Jul 17, 2024
@typescript-bot
Copy link
Contributor

🔔 @microsoft @jkomyno @alvis @r3nya @btoueg @smac89 @Touffy @DeividasBakanas @eyqs @Hannes-Magnusson-CK @hoo29 @kjin @ajafff @islishude @mwiktorczyk @mohsen1 @galkin @parambirs @eps1lon @ThomasdenH @WilcoBakker @wwwy3y3 @samuela @kuehlein @bhongy @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @peterblazejewicz @addaleax @victorperin @ZYSzys @nodejs @LinusU @wafuwafu13 @mcollina @Semigradsky — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot
Copy link
Contributor

@sandersn Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!

@typescript-bot typescript-bot removed the Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. label Jul 17, 2024
@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Jul 17, 2024
@typescript-bot
Copy link
Contributor

@sandersn The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds that are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Jul 18, 2024
@DangerBotOSS
Copy link

DangerBotOSS commented Jul 18, 2024 •
edited
Loading

Formatting

The following files are not formatted:

  1. types/node/dns.d.ts
  2. types/node/tls.d.ts
  3. types/node/crypto.d.ts
  4. types/node/http2.d.ts
  5. types/node/readline.d.ts
as well as these 44 other files...

types/node/diagnostics_channel.d.ts, types/node/stream.d.ts, types/node/process.d.ts, types/node/util.d.ts, types/node/net.d.ts, types/node/dgram.d.ts, types/node/child_process.d.ts, types/node/cluster.d.ts, types/node/fs.d.ts, types/node/http.d.ts, types/node/https.d.ts, types/node/v16/dns.d.ts, types/node/v16/crypto.d.ts, types/node/v16/http2.d.ts, types/node/v16/dgram.d.ts, types/node/v16/child_process.d.ts, types/node/v16/cluster.d.ts, types/node/v16/fs.d.ts, types/node/v16/https.d.ts, types/node/v16/http.d.ts, types/node/zlib.d.ts, types/node/v16/tls.d.ts, types/node/v16/readline.d.ts, types/node/v16/process.d.ts, types/node/v16/stream.d.ts, types/node/v16/net.d.ts, types/node/v16/util.d.ts, types/node/v18/async_hooks.d.ts, types/node/v18/dns.d.ts, types/node/v18/tls.d.ts, types/node/v18/crypto.d.ts, types/node/v18/http2.d.ts, types/node/v18/readline.d.ts, types/node/v18/diagnostics_channel.d.ts, types/node/v18/stream.d.ts, types/node/v18/process.d.ts, types/node/v18/util.d.ts, types/node/v18/net.d.ts, types/node/v18/dgram.d.ts, types/node/v18/child_process.d.ts, types/node/v18/cluster.d.ts, types/node/v18/fs.d.ts, types/node/v18/http.d.ts, types/node/v18/https.d.ts

Consider running pnpm dprint fmt on these files to make review easier.

Generated by 🚫 dangerJS against e6281f0

jakebailey
jakebailey reviewed Jul 18, 2024
View reviewed changes
types/node/assert.d.ts Outdated
@@ -46,7 +46,7 @@ declare module "assert" {
operator?: string | undefined;
/** If provided, the generated stack trace omits frames before this function. */
// eslint-disable-next-line @typescript-eslint/ban-types
stackStartFn?: Function | undefined;
/** @deferred */ stackStartFn?: Function | undefined;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one definitely doesn't work; this tag is not on a parameter. Not sure how many of these are also incorrect, but if you're using a script for this it may need to be tweaked.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one was manual and just I missed the options?: {, although I used find/replace for the nearly all the rest of them which is definitely not going to notice that. I'll try compiling with the branch to see what complaints I get.

@sandersn sandersn mentioned this pull request Jul 18, 2024
Open
@typescript-bot
Copy link
Contributor

@jakebailey Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@DanielRosenwasser DanielRosenwasser mentioned this pull request Jul 19, 2024
Open
@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Jul 29, 2024
@typescript-bot
Copy link
Contributor

Re-ping @microsoft, @jkomyno, @alvis, @r3nya, @btoueg, @smac89, @Touffy, @DeividasBakanas, @eyqs, @Hannes-Magnusson-CK, @hoo29, @kjin, @ajafff, @islishude, @mwiktorczyk, @mohsen1, @galkin, @parambirs, @eps1lon, @ThomasdenH, @WilcoBakker, @wwwy3y3, @samuela, @kuehlein, @bhongy, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @ZYSzys, @nodejs, @LinusU, @wafuwafu13, @mcollina, @Semigradsky:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@jakebailey jakebailey marked this pull request as draft July 29, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebailey jakebailey jakebailey left review comments

@eps1lon eps1lon Awaiting requested review from eps1lon eps1lon is a code owner

@peterblazejewicz peterblazejewicz Awaiting requested review from peterblazejewicz peterblazejewicz is a code owner

Assignees
No one assigned
Labels
Check Config Changes a module config files Critical package Huge Change Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer.
Projects
Pull Request Status Board
Status: Needs Author Action
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sandersn @typescript-bot @DangerBotOSS @jakebailey