Ensure that one-way implicit conversions also work for value types #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #287 +/- ##
=========================================
+ Coverage 87.2% 87.5% +0.29%
=========================================
Files 42 42
Lines 4266 4280 +14
=========================================
+ Hits 3720 3745 +25
+ Misses 546 535 -11
Continue to review full report at Codecov.
|
…urations of implicit conversions
…ed, just to make sure we hit every case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previous PR (#285) fixed a couple issues with one-way implicit conversions, but we still aren't properly checking which type is promotable when comparing value types.
Added some extra logic to fix this. When comparing a value type against a class, we now check for implicit conversions both ways (value type to class, and class to value type). This was already fixed for non-value types, which are handled in a different section of the logic.
Updated the test to hit both the value-type case and the non-value-type case.