import: Use micro-editor/json5 instead of zyedidia/json5
#3595
Conversation
|
Maybe it is better to apply the same Line 36 in d0b3e44 This prevents us from rewriting all the import paths used within the forked dependencies. 🤔 |
| @@ -39,4 +39,4 @@ replace github.com/mattn/go-runewidth => github.com/zyedidia/go-runewidth v0.0.1 | |||
|
|
|||
| replace layeh.com/gopher-luar => github.com/layeh/gopher-luar v1.0.7 | |||
|
|
|||
| go 1.17 | |||
| go 1.19 | |||
There was a problem hiding this comment.
go 1.18 as minimum version would be feasible too.
There was a problem hiding this comment.
I can build it even with 1.17. (Only when I run go mod tidy, it complains "go.mod file indicates go 1.19, but maximum supported version is 1.17", but otherwise seemingly no issue.)
titanous/json5@18a6ca9 doesn't explain why was 1.19 chosen as the minimum version.
Well, 1.19 is already oldish, Debian 12 seems to ship 1.19, so it's probably not a problem if we bump it to 1.19 now.
There was a problem hiding this comment.
Only when I run
go mod tidy
That was the command which guided me in that direction.
titanous/json5@18a6ca9 doesn't explain why was 1.19 chosen as the minimum version.
Maybe a copy-paste "issue".
Well, 1.19 is already oldish, Debian 12 seems to ship 1.19, [...]
Yep, it comes with 1.191.
[...] so it's probably not a problem if we bump it to 1.19 now.
Hopefully.
Footnotes
There was a problem hiding this comment.
Even in the bullseye-backports there is the v1.191.
Footnotes
| github.com/mitchellh/go-homedir v1.1.0 h1:lukF9ziXFxDFPkA1vsr5zpc1XuPDn/wFntq5mG+4E0Y= | ||
| github.com/mitchellh/go-homedir v1.1.0/go.mod h1:SfyaCUpYCn1Vlf4IUYiD9fPX4A5wJrkLzIz1N1q0pr0= | ||
| github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM= | ||
| github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4= | ||
| github.com/rivo/uniseg v0.1.0 h1:+2KBaVoUmb9XzDsrx/Ct0W/EYOSFf/nWTauy++DprtY= | ||
| github.com/rivo/uniseg v0.1.0/go.mod h1:J6wj4VEh+S6ZtnVlnTBMWIodfgj8LQOQFoIToxlJtxc= | ||
| github.com/robertkrimen/otto v0.2.1 h1:FVP0PJ0AHIjC+N4pKCG9yCDz6LHNPCwi/GKID5pGGF0= |
There was a problem hiding this comment.
Just a note: I see you dropped the commit zyedidia/json5@2da050b, I don't know intentionally or not, but as a result you added pulling of this https://github.com/robertkrimen/otto repo which is apparently a JS interpreter (so no wonder it is 1.5MB size, larger than any other micro's external dependencies, including gopher-lua which is only 1MB), which we certainly don't need in micro.
Well, I've checked that it doesn't seem to increase the size of the micro binary (it is the same with and without your PR), so the issue is only in needless downloading and storing of this 1.5MB repo (if the user builds micro from source), which is probably not a big deal if it helps to minimize downstream changes.
There was a problem hiding this comment.
I don't know intentionally or not
It was intentional to keep our downstream changes as low as possible. When we wouldn't use micro-editor/json5@9569b62 then there is even no reason to use a fork at all, as patched by the Debian maintainer(s):
Using the latest forked version of titanous/json5 requires the minimal
goversion to be bumped tov1.19.Fixes #2950