I’m not sure why it doesn’t inherit from std::exception, but other wrappers in other languages handle these exceptions.

This question got me baffled for a moment. I thought, this is an excellent question and why the hell did I not inherit Error from std::exception?!? After looking through the use cases of Error and my memory, I remembered what was behind this decision. To not forget again and for others to be detectable, I decided to add a comment to the Error.h file.

Now to your specific change here: As described in my mentioned comment, Error objects are not meant to be thrown from inside ReadBarcodes, if they are, then this should be considered a bug in the library. Did you encounter such a case prior to introducing #878 ?

Note that the two other implementations you linked to are not catching Error objects but simply anything.

Note that the two other implementations you linked to are not catching Error objects but simply anything.

You're right. Those are catching everything, but basically, they prevent the app from crashing in the case of a ZXing::Error being thrown.

if they are, then this should be considered a bug in the library. Did you encounter such a case prior to introducing #878 ?

Yes, it’s difficult to reproduce. It happens randomly, but the iOS app I'm working on crashes due to a ZXing::Error and an assertion failure.

To quickly fix my app, I decided to catch the ZXing::Error and stop using assertions, as the unexpected crash is not desirable. It may not be the preferred solution, since it simply catches the error, but this is missing in the iOS wrapper.

As described in the comment, the library is not supposed to throw Error objects up the stack into user/wrapper code. Therefore, I'd consider it to be wrong/misleading if we merged this PR as is. I see a point in adding a catch-all clause, to prevent any crash due to unhandled exceptions. Would you be interested in modifying your PR accordingly?

As for the assertions, they (should) disappear in a release built.

Sure. I updated the code to catch any thrown objects.