Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github templates: Add pull request template and update issue template. #365

Merged
merged 1 commit into from
Dec 27, 2017
Merged

github templates: Add pull request template and update issue template. #365

merged 1 commit into from
Dec 27, 2017

Conversation

priyank-p
Copy link
Member

Issue Template:
screen shot 2017-12-27 at 11 13 09 am

Pull Request Template:
screen shot 2017-12-27 at 11 28 06 am

akashnimare
akashnimare reviewed Dec 27, 2017
View reviewed changes
.github/PULL_REQUEST_TEMPLATE.md Outdated

**Any background context you want to provide (if appropriate)?**

**Screenshots (if appropriate)?**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cPhost we can remove (if appropriate here) since we have already included that in header.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@akashnimare akashnimare merged commit afe4e89 into zulip:master Dec 27, 2017
@priyank-p priyank-p deleted the templates branch December 27, 2017 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akashnimare akashnimare akashnimare left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@priyank-p @akashnimare @zulipbot