Redesign the landing page to look more inline with brand design. #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brockwhittaker the page looks great! 👍 you should try running Check this Contributing.md for not failing Travis checks next time. 😄 |
brockwhittaker
force-pushed
the
landing-page-redesign
branch
from
3879d17 to
bb88917
Compare
|
I just fixed all mine but there's still ~25 errors that aren't mine that are present. |
This redesigns the landing page to incorporate the Zulip style guide. This also adds two animations: 1. The error text slides down on error and back up when typing. 2. The form section shakes when there is invalid input for 0.5s.
brockwhittaker
force-pushed
the
landing-page-redesign
branch
from
bb88917 to
c1f6159
Compare
|
@brockwhittaker happens with me too. It's always better if our Pull Request has no JS Lint errors, It takes time to trace those small errors and fix them, but efforts are worth it. you won't ever fail in Travis builds 👍 |
|
@brockwhittaker we could make it better :P but for now, this looks good. Merged. Thanks for working on this 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This redesigns the landing page to incorporate the Zulip style guide.
This also adds two animations: