(wip) presence: Display in the sidebar when bots start and stop. #7938
Conversation
marco
force-pushed
the
announce-bots
branch
7 times, most recently
from
0afd19b to
4a63a2a
Compare
The listening bots are the bots that are currently active on the realm.
marco
force-pushed
the
announce-bots
branch
3 times, most recently
from
17bc1c0 to
638020d
Compare
`do_mark_bot_listening` can be called to add a bot's name to the `listening` list. It can also be used to remove bots. Whenever `do_mark_bot_listening` is called, it uses `do_set_realm_property` to start a `realm`-type event.
marco
force-pushed
the
announce-bots
branch
3 times, most recently
from
eb187e9 to
6c449a2
Compare
`realm/mark_bot_listening` takes 2 options: `bot_name` and `is_listening`. `python-zulip-api` can use `realm/mark_bot_listening` in `zulip-run-bot` to add a bot to the `listening` list.
Display the listening bots underneath the user presence list. Each bot should have a green "active" dot next to it and a bot icon to the right. Fix zulip/python-zulip-api#151
marco
changed the title
showell
changed the title
|
I put "wip" in the title to reflect that we need a slightly different approach here. @skunkmb You can inform your GCI mentor that I'm satisfied with this PR in terms of GCI credit, even though we'll need more work to merge it. |
|
@showell @roberthoenig Hello! What is the current status of this? Is there anything I should be working on? I know we discussed that possibly @roberthoenig would do some work on the backend and after that I would rebase this to contain only frontend changes. There is no rush, I just wanted to make sure that there isn't something that I should be working on. Thanks! 😃 |
|
@skunkmb sorry, missed your comment. So this is the next thing I'll be working on, probably rewriting the backend code to the changes we discussed, and reusing your frontend code. Will ping you in any new PRs on this. |
|
@roberthoenig OK, great, thanks! |
|
Heads up @skunkmb, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
timabbott
force-pushed
the
main
branch
2 times, most recently
from
4ec3636 to
88b200c
Compare
This allows bots to be marked as
listening, and displays them in the sidebar if they are.For example,
For this to work, it would require zulip/python-zulip-api#271 to be merged in order to call the
realm/mark_bot_listeningendpoint whenzulip-run-botis called.(Done for the "Issue zulip/python-zulip-api#151 [Feature proposal] Make bots announce their startup/shutdown." Google Code-in task.)