-
-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
login-pages: Clean up split view left side styling. #4767
Conversation
Automated message from Dropbox CLA bot @brockwhittaker, it looks like you've already signed the Dropbox CLA. Thanks! |
522f950
to
00c7403
Compare
Updated to solve new merge conflicts @timabbott. |
f2511d4
to
df87b4c
Compare
@brockwhittaker I think this problem (not enough space for longer organization titles) is still a very real one. Do you think fixing the reload problem I mentioned is feasible? I guess a strategy that I can see working would be to have the login page section at the center of the page be hidden until we've determined the size, and we only show it then? |
Heads up @brockwhittaker, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
This cleans up the left side of the split view to have better font size management and styling.
df87b4c
to
c9a37ec
Compare
Heads up @brockwhittaker, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
Heads up @brockwhittaker, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
Closing this as I don't think this sort of dynamic text size approach is viable. |
This cleans up the left side of the split view to have better
font size management and styling.