Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

login-pages: Clean up split view left side styling. #4767

Closed

Conversation

brockwhittaker
Copy link
Collaborator

This cleans up the left side of the split view to have better
font size management and styling.

@smarx
Copy link

smarx commented May 12, 2017

Automated message from Dropbox CLA bot

@brockwhittaker, it looks like you've already signed the Dropbox CLA. Thanks!

@brockwhittaker brockwhittaker force-pushed the organization-name-fix branch 2 times, most recently from 522f950 to 00c7403 Compare May 12, 2017 00:56
@brockwhittaker
Copy link
Collaborator Author

Updated to solve new merge conflicts @timabbott.

@brockwhittaker brockwhittaker force-pushed the organization-name-fix branch 4 times, most recently from f2511d4 to df87b4c Compare May 12, 2017 01:31
@timabbott
Copy link
Member

If I reload this alternately using ctrl-R vs ctrl-shift-R, I get different sizes:

image

image

@timabbott
Copy link
Member

timabbott commented Aug 23, 2017

@brockwhittaker I think this problem (not enough space for longer organization titles) is still a very real one. Do you think fixing the reload problem I mentioned is feasible?

I guess a strategy that I can see working would be to have the login page section at the center of the page be hidden until we've determined the size, and we only show it then?

@zulipbot-test
Copy link

Heads up @brockwhittaker, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/master branch and resolve your pull request's merge conflicts accordingly.

This cleans up the left side of the split view to have better
font size management and styling.
@zulip zulip deleted a comment from zulipbot Aug 23, 2017
@zulipbot
Copy link
Member

Heads up @brockwhittaker, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/master branch and resolve your pull request's merge conflicts accordingly.

@zulipbot
Copy link
Member

zulipbot commented Nov 21, 2017

Heads up @brockwhittaker, we just merged some commits that conflict with the changes your made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/master branch and resolve your pull request's merge conflicts accordingly.

@timabbott
Copy link
Member

Closing this as I don't think this sort of dynamic text size approach is viable.

@timabbott timabbott closed this May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants