import: Sort realms migrations status before checking. #32866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit sorts the list of migrations to ensure the same sets of migrations don't somehow ordered differently. This has been reported to happen when importing Zulip Cloud to self-host (zulip-cloud-current). The order of migrations listed in `migration_status.json` don't actually matter, migrations specify which other migrations they depend on. Fixes zulip#32826.
PieterCK
force-pushed
the
fix-check-migrations-status
branch
from
9e67a69 to
8e64e3b
Compare
alya
added
the
integration review
|
@timabbott tagging for you to take a look. |
|
This is great, merged, thanks @PieterCK! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sorts the list of migrations to ensure the same
sets of migrations don't somehow order differently. This
has been reported to happen when importing Zulip Cloud to
self-host (zulip-cloud-current).
The order of migrations listed in
migration_status.jsondon't actually matter, migrations specify which other
migrations they depend on.
https://docs.djangoproject.com/en/5.1/topics/migrations/
Fixes #32826.
CZO
Screenshots and screen captures:
Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: