Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unresolved: Add support for searching for unresolved topics. #32810

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

unresolved: Add support for searching for unresolved topics. #32810

wants to merge 2 commits into from

Conversation

shuklamaneesh23
Copy link
Collaborator

@shuklamaneesh23 shuklamaneesh23 commented Dec 23, 2024 •
edited
Loading

This PR adds support for searching unresolved topics.

It achieves this in the following ways:

  • Rename "Topics marked as resolved" -> "Resolved topics".
  • Adds 'Unresolved Topics' to the typeahead, which inserts -is:resolved into the search pill.
  • Updates conditions to display 'Unresolved Topics' instead of 'Exclude topic marked as resolved.'
  • Modifies conditions to correctly show the last searched option as 'Unresolved Topics.'

Fixes: #31725.

Screenshots and screen captures:

Unresolved and Resolved in the typeahead: Screenshot 2025-01-24 at 2 34 06 AM Screenshot 2025-01-15 at 8 00 38 PM
Unresolved in the history of last searched option: Screenshot 2025-01-15 at 8 00 59 PM
Resolved Topics Heading: Screenshot 2025-01-24 at 2 33 34 AM
Unresolved Topics in `?` menu: Screenshot 2025-01-24 at 2 37 26 AM
Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@zulipbot
Copy link
Member

Hello @zulip/server-search members, this pull request was labeled with the "area: search" label, so you may want to check it out!

@shuklamaneesh23 shuklamaneesh23 mentioned this pull request Jan 6, 2025
Open
@shuklamaneesh23 shuklamaneesh23 force-pushed the unresolved branch 2 times, most recently from e80d89e to 940da6e Compare January 15, 2025 13:58
@zulipbot zulipbot added size: L and removed size: M labels Jan 15, 2025
@shuklamaneesh23 shuklamaneesh23 marked this pull request as ready for review January 15, 2025 15:08
@shuklamaneesh23
Copy link
Collaborator Author

Hi @alya , would you like to test the behaviour manually?
Thanks!

@shuklamaneesh23
Copy link
Collaborator Author

Hi @alya , could you please take a look at this?
Thanks!

@alya
Copy link
Contributor

alya commented Jan 21, 2025

Cool, works for me in manual testing.

Let's also rename "Topics marked as resolved" -> "Resolved topics".

@alya
Copy link
Contributor

alya commented Jan 21, 2025

And let's document how to search for unresolved topics in the ? menu, right after resolved topics:

Screenshot 2025-01-21 at 15 14 58

It's already documented in the help center.

@alya
Copy link
Contributor

alya commented Jan 21, 2025

Once you've made these tweaks, can you see if @PieterCK has time to review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area: search priority: high size: L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make it easier to search for unresolved topics
3 participants
@shuklamaneesh23 @zulipbot @alya