Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

left_sidebar: Add Alerts View to the left sidebar. #28858

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

left_sidebar: Add Alerts View to the left sidebar. #28858

wants to merge 4 commits into from

Conversation

roanster007
Copy link
Collaborator

@roanster007 roanster007 commented Feb 7, 2024 •
edited
Loading

This PR adds the Alerts View to the left sidebar.

Commits:

  • 18b5f6c: Preparatory commit.
  • be48d38: Adds the Alerts view to the left sidebar both in condensed and non condensed view (without unread counts).
  • d3b6d5d: Adds the narrow banner, and message_view_header to the Alerts View.
  • d818825: Adds the unread count to the Alerts View.

Fixes: #28778

Screenshots and screen captures:
image


image


image
When alert words and corresponding messages exist.


image
When alert words exist but corresponding messages don't


image
Views when alert words don't exist.


brave_EPcuJ3sSAX
Opening of settings from 3 dot menu.

Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@zulipbot zulipbot added size: XL area: left sidebar (features) New left sidebar functionality difficult Issues which we expect to be quite difficult new feature A proposed new feature for the product labels Feb 7, 2024
@roanster007 roanster007 marked this pull request as draft February 7, 2024 10:09
@roanster007 roanster007 force-pushed the is-28778 branch 2 times, most recently from 0006e37 to 4b54af3 Compare February 7, 2024 14:53
@roanster007 roanster007 marked this pull request as ready for review February 7, 2024 15:16
@roanster007
Copy link
Collaborator Author

roanster007 commented Feb 7, 2024 •
edited
Loading

I guess since the api changes are so minimal and obvious (similar to mentions)... does this still require an api design thread?

@alya
Copy link
Contributor

alya commented Feb 9, 2024

Yes, please start one.

@roanster007
Copy link
Collaborator Author

API Design Thread

@roanster007
Copy link
Collaborator Author

@alya please do let me know when the icon for this View is confirmed. I'll then rebase and update the pr.

@alya
Copy link
Contributor

alya commented Feb 21, 2024

Sure, but I don't think the icon is a blocker for proceeding here. Will the PR be ready for review once you've resolved conflicts, or is there more you need to do?

@roanster007
Copy link
Collaborator Author

yup, the icon was the only thing left...I guess I'll rebase the pr then.

@roanster007
left_sidebar_nav_area: Refactor handle_narrow_activated filter_name.
346d0d3 
This commit refactors the handle_narrow_activated method of
the left_sidebar_navigation_area to use a switch case instead
of an if-else in the filter_name.

This is a preparatory commit for zulip#28778.
@roanster007
left_sidebar: Add Alerts views.
c68a12c 
This commit adds a new Alerts view to the left sidebar, clicking
on which narrows to "is: alerted" messages. This view is only
present when the user has chosen some alert words

It adds 3 dot menu to it linking to the Alert word settings.

It also adds the Alerts view to the condensed view.

Fixes part of zulip#28778.
@roanster007
Alerts: Add message_view_header and narrow_banner for alert views.
ccc9991 
This commit adds the message_view_header to the alert views.

It also adds the narrow banner to display when no message with
matching alert words is found.
@roanster007
left_sidebar: Add unread counts to the Alert Views.
f54089d 
This commit adds the unread counts to the Alert Views, both in
condensed and non condensed state.

Fixes: zulip#28778.
@zulipbot
Copy link
Member

Heads up @roanster007, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the upstream/main branch and resolve your pull request's merge conflicts accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area: left sidebar (features) New left sidebar functionality difficult Issues which we expect to be quite difficult has conflicts new feature A proposed new feature for the product size: XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "Alert words" view to left sidebar
3 participants
@roanster007 @alya @zulipbot