Fix early reads of page_params #28389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For spectators, page_params.custom_profile_field_types has not been initialized yet at module load time. Signed-off-by: Anders Kaseorg <anders@zulip.com>
For spectators, page_params.realm_create_public_stream_policy, page_params.server_web_public_streams_enabled, page_params.realm_enable_spectator_access have not been initialized yet at module load time. Signed-off-by: Anders Kaseorg <anders@zulip.com>
For spectators, page_params.server_typing_started_wait_period_milliseconds and page_params.server_typing_stopped_wait_period_milliseconds have not been initialized yet at module load time. Signed-off-by: Anders Kaseorg <anders@zulip.com>
For spectators, page_params.server_typing_started_expiry_period_milliseconds has not been initialized yet at module load time. Signed-off-by: Anders Kaseorg <anders@zulip.com>
andersk
force-pushed
the
page_params-early
branch
from
791bede to
1d3b0de
Compare
andersk
added
the
integration review
|
Merged, thanks @andersk! I don't think these are live bugs deserving to be backported, in that the code in question is I think not available to spectators. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For spectators, most of
page_paramshas not been initialized yet at module load time.